Skip to content

Properly parse the names form manifest.contributors#3364

Merged
mirpedrol merged 2 commits into
nf-core:devfrom
mirpedrol:fix-3361-rocrate-contributors
Dec 20, 2024
Merged

Properly parse the names form manifest.contributors#3364
mirpedrol merged 2 commits into
nf-core:devfrom
mirpedrol:fix-3361-rocrate-contributors

Conversation

@mirpedrol

Copy link
Copy Markdown
Member

Close #3361

@mirpedrol mirpedrol requested a review from mashehu December 17, 2024 14:53
@codecov

codecov Bot commented Dec 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.97%. Comparing base (728a91c) to head (5ecf583).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/rocrate.py 80.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol force-pushed the fix-3361-rocrate-contributors branch from cf43911 to 5ecf583 Compare December 17, 2024 15:09
@mirpedrol mirpedrol enabled auto-merge December 17, 2024 15:55
@ewels ewels added this to the 3.1.1 milestone Dec 19, 2024

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants