Skip to content

Add nf-core template version badges to README#3396

Merged
mirpedrol merged 14 commits into
devfrom
version-badges
Feb 13, 2025
Merged

Add nf-core template version badges to README#3396
mirpedrol merged 14 commits into
devfrom
version-badges

Conversation

@jfy133

@jfy133 jfy133 commented Jan 14, 2025

Copy link
Copy Markdown
Member

Should add automation to bump the template version on sync, but that's for cleverer people than myself.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 requested a review from mirpedrol January 14, 2025 09:45

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge version will update when updating the template now. I have also fixed the bump-version command and lining.
I will let @mashehu or someone else review my code since I added quite a bit 😄

@mirpedrol mirpedrol requested a review from mashehu February 12, 2025 16:00
@codecov

codecov Bot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.49%. Comparing base (38813b0) to head (08e0d7e).
Report is 43 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/lint/readme.py 85.71% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing about what to link, rest looks good

Comment thread nf_core/pipeline-template/README.md Outdated
Comment thread nf_core/pipelines/create/template_features.yml Outdated
mirpedrol and others added 2 commits February 13, 2025 10:33
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol mirpedrol merged commit abb3acf into dev Feb 13, 2025
@mirpedrol mirpedrol deleted the version-badges branch February 13, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants