Skip to content

format name/value with YAML syntax#3442

Merged
matbonfanti merged 3 commits into
nf-core:devfrom
matbonfanti:fix-params-yaml-format
Feb 6, 2025
Merged

format name/value with YAML syntax#3442
matbonfanti merged 3 commits into
nf-core:devfrom
matbonfanti:fix-params-yaml-format

Conversation

@matbonfanti

@matbonfanti matbonfanti commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

This PR fixes the incorrect formatting of the params file generated by the nf-core pipelines create-params-file command (issue #3441). The output written with the name = value format has been corrected to name: value.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mashehu mashehu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread nf_core/pipelines/params_file.py
Comment thread tests/pipelines/test_params_file.py
@codecov

codecov Bot commented Feb 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (639e419) to head (02dcbb7).
Report is 4 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbonfanti

Copy link
Copy Markdown
Contributor Author

@mashehu, if you think that all is fine with the code changes, can you please merge the PR?

@mashehu

mashehu commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

I added you to the nf-core org, so you should have rights to merge the PR yourself and don't need to wait on me 🙂

@matbonfanti

Copy link
Copy Markdown
Contributor Author

awesome! thanks!

@matbonfanti matbonfanti merged commit 1f84814 into nf-core:dev Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants