Skip to content

Refactor adding EDAM ontologies and allowing detect more patterns (e.g., versions.yml)#3519

Merged
toniher merged 7 commits into
nf-core:devfrom
toniher:further-check-ontology
Mar 28, 2025
Merged

Refactor adding EDAM ontologies and allowing detect more patterns (e.g., versions.yml)#3519
toniher merged 7 commits into
nf-core:devfrom
toniher:further-check-ontology

Conversation

@toniher

@toniher toniher commented Mar 27, 2025

Copy link
Copy Markdown
Member

Refactor ontologies addition code (common in input and output)

Addressing assignation of files (versions.yml) and also addressing issues such as #3496

@toniher toniher requested a review from mirpedrol March 27, 2025 17:51
@codecov

codecov Bot commented Mar 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (8d21cdf) to head (e8769c0).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/modules/lint/__init__.py 89.65% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirpedrol mirpedrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice that you could reduce code duplication 👏

Comment thread nf_core/modules/lint/__init__.py Outdated
missing ontologies key

Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@toniher toniher merged commit 52dfee6 into nf-core:dev Mar 28, 2025
@toniher toniher deleted the further-check-ontology branch March 28, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants