don't read param expressions with spaces as params#3674
Conversation
mashehu
left a comment
There was a problem hiding this comment.
Maybe add a test for this so we don't run into it in the future?
It's a regular expression, not sure we need a test for this. There is no way we can know what code people is going to add that will not match our regex |
Codecov ReportAll modified and coverable lines are covered by tests ✅
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
i just want to basically have a list of cases this regex should cover so we now we don't break anything if we for example can replace this with reftrace |
|
spaces, not equals? |
My description was not very good 😅 The error happened when there was an equal but I am now fixing it by not considering any param name that contains spaces. |
Close #3672
https://regex101.com/r/xuh0TQ/1
The expressions that contain spaces are not read as if they were param variables.