Skip to content

don't read param expressions with spaces as params#3674

Merged
mirpedrol merged 3 commits into
nf-core:devfrom
mirpedrol:schema-params-regex
Jul 15, 2025
Merged

don't read param expressions with spaces as params#3674
mirpedrol merged 3 commits into
nf-core:devfrom
mirpedrol:schema-params-regex

Conversation

@mirpedrol

Copy link
Copy Markdown
Member

Close #3672

https://regex101.com/r/xuh0TQ/1
The expressions that contain spaces are not read as if they were param variables.

@mirpedrol mirpedrol requested review from mashehu and maxulysse July 10, 2025 08:38

@mashehu mashehu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for this so we don't run into it in the future?

@mirpedrol

Copy link
Copy Markdown
Member Author

Maybe add a test for this so we don't run into it in the future?

It's a regular expression, not sure we need a test for this. There is no way we can know what code people is going to add that will not match our regex

@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (28b76a4) to head (587b816).
Report is 4 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu

mashehu commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

i just want to basically have a list of cases this regex should cover so we now we don't break anything if we for example can replace this with reftrace

@maxulysse

Copy link
Copy Markdown
Member

spaces, not equals?

@mirpedrol

Copy link
Copy Markdown
Member Author

spaces, not equals?

My description was not very good 😅 The error happened when there was an equal but I am now fixing it by not considering any param name that contains spaces.

@mirpedrol mirpedrol merged commit 3e51a72 into nf-core:dev Jul 15, 2025
99 checks passed
@mirpedrol mirpedrol deleted the schema-params-regex branch July 15, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants