Improve validation of run_accessions IDs within sample IDs#484
Merged
Conversation
|
Member
Author
|
@nf-core-bot fix linting |
sofstam
reviewed
May 8, 2024
sofstam
left a comment
Collaborator
There was a problem hiding this comment.
Tested and it detects if a run_accession and a sample Id are not unique.
Contributor
|
I'm just wondering, are there good cases for when a run accession should not be globally unique, but only within a sample? |
Member
Author
Do you approve then @sofstam ? |
Member
Author
Depends on naming schemes basically... My definition of a run was based on ENA run accessions where they were were unique. But @sofstam had an issue where they were not unique, as they were interpreted as a sequencing run accession (so in the table, the same sequencing run was shared across all the samples). |
Collaborator
|
I approve, shall but shall we merge the template first? |
sofstam
approved these changes
May 16, 2024
sofstam
left a comment
Collaborator
There was a problem hiding this comment.
The linting should be fixed before merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully close #483
PR checklist
nf-core lint).nf-test test main.nf.test -profile test,docker).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).