Add abi and custom adapters options to porechop_abi by LilyAnderssonLee · Pull Request #591 · nf-core/taxprofiler

LilyAnderssonLee · 2025-03-25T10:14:24Z

Add params.longread_qc_predictadapters and params.longread_qc_adapterlist as ext.args for the module PORECHOP_ABI suggested by @AlexHoratio #589

PR checklist

…list to porechop_abi

github-actions · 2025-03-25T10:51:59Z

`nf-core pipelines lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit 4b6fbb9

+| ✅ 281 tests passed       |+
!| ❗  18 tests had warnings |!

Details

❗ Test warnings:

files_exist - File not found: conf/igenomes.config
files_exist - File not found: conf/igenomes_ignored.config
pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
local_component_structure - krona_cleanup.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
local_component_structure - kraken2_standard_report.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
local_component_structure - shortread_preprocessing.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - standardisation_profiles.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - longread_filtering.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - profiling.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - shortread_hostremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - visualization_krona.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - longread_adapterremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - longread_preprocessing.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - shortread_adapterremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - shortread_fastp.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - nonpareil.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - longread_hostremoval.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - shortread_complexityfiltering.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .editorconfig
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/ci.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: assets/nf-core-taxprofiler_logo_light.png
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: conf/test_full.config
files_exist - File found: docs/images/nf-core-taxprofiler_logo_light.png
files_exist - File found: docs/images/nf-core-taxprofiler_logo_dark.png
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: .github/workflows/awstest.yml
files_exist - File found: .github/workflows/awsfulltest.yml
files_exist - File found: modules.json
files_exist - File found: ro-crate-metadata.json
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: docs/images/nf-core-taxprofiler_logo.png
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/NfcoreTemplate.groovy
files_exist - File not found check: lib/Utils.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: lib/WorkflowMain.groovy
files_exist - File not found check: lib/WorkflowTaxprofiler.groovy
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: pipeline_template.yml
files_exist - File not found check: Singularity
files_exist - File not found check: lib/nfcore_external_java_deps.jar
files_exist - File not found check: .travis.yml
nextflow_config - Found nf-schema plugin
nextflow_config - Config variable found: manifest.name
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: manifest.homePage
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.input
nextflow_config - Config variable found: validation.help.enabled
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable found: validation.help.beforeText
nextflow_config - Config variable found: validation.help.afterText
nextflow_config - Config variable found: validation.help.command
nextflow_config - Config variable found: validation.summary.beforeText
nextflow_config - Config variable found: validation.summary.afterText
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config variable (correctly) not found: params.max_cpus
nextflow_config - Config variable (correctly) not found: params.max_memory
nextflow_config - Config variable (correctly) not found: params.max_time
nextflow_config - Config variable (correctly) not found: params.validationFailUnrecognisedParams
nextflow_config - Config variable (correctly) not found: params.validationLenientMode
nextflow_config - Config variable (correctly) not found: params.validationSchemaIgnoreParams
nextflow_config - Config variable (correctly) not found: params.validationShowHiddenParams
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config manifest.name began with nf-core/
nextflow_config - Config variable manifest.homePage began with https://github.com/nf-core/
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config manifest.version ends in dev: 1.3.0dev
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
nextflow_config - nextflow.config contains configuration profile test
nextflow_config - Config default value correct: params.preprocessing_qc_tool= fastqc
nextflow_config - Config default value correct: params.shortread_qc_tool= fastp
nextflow_config - Config default value correct: params.shortread_qc_minlength= 15
nextflow_config - Config default value correct: params.shortread_complexityfilter_tool= bbduk
nextflow_config - Config default value correct: params.shortread_complexityfilter_entropy= 0.3
nextflow_config - Config default value correct: params.shortread_complexityfilter_bbduk_windowsize= 50
nextflow_config - Config default value correct: params.shortread_complexityfilter_fastp_threshold= 30
nextflow_config - Config default value correct: params.shortread_complexityfilter_prinseqplusplus_mode= entropy
nextflow_config - Config default value correct: params.shortread_complexityfilter_prinseqplusplus_dustscore= 0.5
nextflow_config - Config default value correct: params.longread_adapterremoval_tool= porechop_abi
nextflow_config - Config default value correct: params.longread_filter_tool= nanoq
nextflow_config - Config default value correct: params.longread_qc_qualityfilter_minlength= 1000
nextflow_config - Config default value correct: params.longread_qc_qualityfilter_keeppercent= 90
nextflow_config - Config default value correct: params.longread_qc_qualityfilter_targetbases= 500000000
nextflow_config - Config default value correct: params.longread_qc_qualityfilter_minquality= 7
nextflow_config - Config default value correct: params.shortread_redundancyestimation_mode= kmer
nextflow_config - Config default value correct: params.diamond_output_format= tsv
nextflow_config - Config default value correct: params.kaiju_taxon_rank= species
nextflow_config - Config default value correct: params.krakenuniq_ram_chunk_size= 16G
nextflow_config - Config default value correct: params.krakenuniq_batch_size= 20
nextflow_config - Config default value correct: params.malt_mode= BlastN
nextflow_config - Config default value correct: params.motus_longprep_splittinglength= 300
nextflow_config - Config default value correct: params.motus_longprep_minlen= 50
nextflow_config - Config default value correct: params.ganon_report_type= reads
nextflow_config - Config default value correct: params.ganon_report_rank= default
nextflow_config - Config default value correct: params.ganon_report_toppercentile= 0
nextflow_config - Config default value correct: params.ganon_report_mincount= 0
nextflow_config - Config default value correct: params.ganon_report_maxcount= 0
nextflow_config - Config default value correct: params.standardisation_taxpasta_format= tsv
nextflow_config - Config default value correct: params.custom_config_version= master
nextflow_config - Config default value correct: params.custom_config_base= https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Config default value correct: params.publish_dir_mode= copy
nextflow_config - Config default value correct: params.max_multiqc_email_size= 25.MB
nextflow_config - Config default value correct: params.validate_params= true
nextflow_config - Config default value correct: params.pipelines_testdata_base_path= https://raw.githubusercontent.com/nf-core/test-datasets/
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - CODE_OF_CONDUCT.md matches the template
files_unchanged - LICENSE matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/CONTRIBUTING.md matches the template
files_unchanged - .github/ISSUE_TEMPLATE/bug_report.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/config.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/PULL_REQUEST_TEMPLATE.md matches the template
files_unchanged - .github/workflows/branch.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - .github/workflows/linting.yml matches the template
files_unchanged - assets/email_template.html matches the template
files_unchanged - assets/email_template.txt matches the template
files_unchanged - assets/sendmail_template.txt matches the template
files_unchanged - assets/nf-core-taxprofiler_logo_light.png matches the template
files_unchanged - docs/images/nf-core-taxprofiler_logo_light.png matches the template
files_unchanged - docs/images/nf-core-taxprofiler_logo_dark.png matches the template
files_unchanged - docs/README.md matches the template
files_unchanged - .gitignore matches the template
files_unchanged - .prettierignore matches the template
actions_ci - '.github/workflows/ci.yml' is triggered on expected events
actions_ci - '.github/workflows/ci.yml' checks minimum NF version
actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
readme - README Nextflow minimum version badge matched config. Badge: 24.04.2, Config: 24.04.2
readme - README Zenodo placeholder was replaced with DOI.
plugin_includes - No wrong validation plugin imports have been found
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (0 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_lint - Input mimetype lint passed: 'text/csv'
schema_params - Schema matched params returned from nextflow config
system_exit - No System.exit calls found
actions_schema_validation - Workflow validation passed: download_pipeline.yml
actions_schema_validation - Workflow validation passed: ci.yml
actions_schema_validation - Workflow validation passed: release-announcements.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: template_version_comment.yml
actions_schema_validation - Workflow validation passed: awstest.yml
actions_schema_validation - Workflow validation passed: linting.yml
actions_schema_validation - Workflow validation passed: awsfulltest.yml
actions_schema_validation - Workflow validation passed: clean-up.yml
actions_schema_validation - Workflow validation passed: fix-linting.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - assets/multiqc_config.yml found and not ignored.
multiqc_config - assets/multiqc_config.yml contains report_section_order
multiqc_config - assets/multiqc_config.yml contains export_plots
multiqc_config - assets/multiqc_config.yml contains report_comment
multiqc_config - assets/multiqc_config.yml follows the ordering scheme of the minimally required plugins.
multiqc_config - assets/multiqc_config.yml contains a matching 'report_comment'.
multiqc_config - assets/multiqc_config.yml contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
base_config - conf/base.config found and not ignored.
base_config - BRACKEN_BRACKEN found in conf/base.config and Nextflow scripts.
base_config - CENTRIFUGE_KREPORT found in conf/base.config and Nextflow scripts.
base_config - KRAKENTOOLS_COMBINEKREPORTS_CENTRIFUGE found in conf/base.config and Nextflow scripts.
base_config - MEGAN_RMA2INFO_TSV found in conf/base.config and Nextflow scripts.
base_config - MEGAN_RMA2INFO_KRONA found in conf/base.config and Nextflow scripts.
base_config - FALCO found in conf/base.config and Nextflow scripts.
modules_config - conf/modules.config found and not ignored.
modules_config - UNTAR found in conf/modules.config and Nextflow scripts.
modules_config - FASTQC found in conf/modules.config and Nextflow scripts.
modules_config - FASTQC_PROCESSED found in conf/modules.config and Nextflow scripts.
modules_config - FALCO found in conf/modules.config and Nextflow scripts.
modules_config - FALCO_PROCESSED found in conf/modules.config and Nextflow scripts.
modules_config - FASTP_SINGLE found in conf/modules.config and Nextflow scripts.
modules_config - FASTP_PAIRED found in conf/modules.config and Nextflow scripts.
modules_config - ADAPTERREMOVAL_SINGLE found in conf/modules.config and Nextflow scripts.
modules_config - ADAPTERREMOVAL_PAIRED found in conf/modules.config and Nextflow scripts.
modules_config - NONPAREIL_NONPAREIL found in conf/modules.config and Nextflow scripts.
modules_config - NONPAREIL_CURVE found in conf/modules.config and Nextflow scripts.
modules_config - NONPAREIL_SET found in conf/modules.config and Nextflow scripts.
modules_config - NONPAREIL_NONPAREILCURVESR found in conf/modules.config and Nextflow scripts.
modules_config - CAT_FASTQ found in conf/modules.config and Nextflow scripts.
modules_config - PORECHOP_PORECHOP found in conf/modules.config and Nextflow scripts.
modules_config - PORECHOP_ABI found in conf/modules.config and Nextflow scripts.
modules_config - FILTLONG found in conf/modules.config and Nextflow scripts.
modules_config - NANOQ found in conf/modules.config and Nextflow scripts.
modules_config - BBMAP_BBDUK found in conf/modules.config and Nextflow scripts.
modules_config - PRINSEQPLUSPLUS found in conf/modules.config and Nextflow scripts.
modules_config - BOWTIE2_BUILD found in conf/modules.config and Nextflow scripts.
modules_config - BOWTIE2_ALIGN found in conf/modules.config and Nextflow scripts.
modules_config - MINIMAP2_INDEX found in conf/modules.config and Nextflow scripts.
modules_config - MINIMAP2_ALIGN found in conf/modules.config and Nextflow scripts.
modules_config - SAMTOOLS_VIEW found in conf/modules.config and Nextflow scripts.
modules_config - SAMTOOLS_FASTQ found in conf/modules.config and Nextflow scripts.
modules_config - SAMTOOLS_STATS found in conf/modules.config and Nextflow scripts.
modules_config - MERGE_RUNS found in conf/modules.config and Nextflow scripts.
modules_config - MALT_RUN found in conf/modules.config and Nextflow scripts.
modules_config - MEGAN_RMA2INFO_TSV found in conf/modules.config and Nextflow scripts.
modules_config - KRAKEN2_KRAKEN2 found in conf/modules.config and Nextflow scripts.
modules_config - KRAKEN2_STANDARD_REPORT found in conf/modules.config and Nextflow scripts.
modules_config - BRACKEN_BRACKEN found in conf/modules.config and Nextflow scripts.
modules_config - BRACKEN_COMBINEBRACKENOUTPUTS found in conf/modules.config and Nextflow scripts.
modules_config - KRAKENTOOLS_COMBINEKREPORTS_KRAKEN found in conf/modules.config and Nextflow scripts.
modules_config - KRAKENUNIQ_PRELOADEDKRAKENUNIQ found in conf/modules.config and Nextflow scripts.
modules_config - KRAKENTOOLS_KREPORT2KRONA found in conf/modules.config and Nextflow scripts.
modules_config - KRONA_CLEANUP found in conf/modules.config and Nextflow scripts.
modules_config - KRONA_KTIMPORTTEXT found in conf/modules.config and Nextflow scripts.
modules_config - MEGAN_RMA2INFO_KRONA found in conf/modules.config and Nextflow scripts.
modules_config - KRONA_KTIMPORTTAXONOMY found in conf/modules.config and Nextflow scripts.
modules_config - METAPHLAN_METAPHLAN found in conf/modules.config and Nextflow scripts.
modules_config - METAPHLAN_MERGEMETAPHLANTABLES found in conf/modules.config and Nextflow scripts.
modules_config - CENTRIFUGE_CENTRIFUGE found in conf/modules.config and Nextflow scripts.
modules_config - CENTRIFUGE_KREPORT found in conf/modules.config and Nextflow scripts.
modules_config - KRAKENTOOLS_COMBINEKREPORTS_CENTRIFUGE found in conf/modules.config and Nextflow scripts.
modules_config - KAIJU_KAIJU found in conf/modules.config and Nextflow scripts.
modules_config - KAIJU_KAIJU2TABLE_SINGLE found in conf/modules.config and Nextflow scripts.
modules_config - KAIJU_KAIJU2TABLE_COMBINED found in conf/modules.config and Nextflow scripts.
modules_config - KAIJU_KAIJU2KRONA found in conf/modules.config and Nextflow scripts.
modules_config - DIAMOND_BLASTX found in conf/modules.config and Nextflow scripts.
modules_config - MOTUS_PROFILE found in conf/modules.config and Nextflow scripts.
modules_config - MOTUS_PREPLONG found in conf/modules.config and Nextflow scripts.
modules_config - MOTUS_MERGE found in conf/modules.config and Nextflow scripts.
modules_config - KMCP_SEARCH found in conf/modules.config and Nextflow scripts.
modules_config - KMCP_PROFILE found in conf/modules.config and Nextflow scripts.
modules_config - GANON_CLASSIFY found in conf/modules.config and Nextflow scripts.
modules_config - GANON_REPORT found in conf/modules.config and Nextflow scripts.
modules_config - GANON_TABLE found in conf/modules.config and Nextflow scripts.
modules_config - TAXPASTA_MERGE found in conf/modules.config and Nextflow scripts.
modules_config - TAXPASTA_STANDARDISE found in conf/modules.config and Nextflow scripts.
modules_config - MULTIQC found in conf/modules.config and Nextflow scripts.
nfcore_yml - Repository type in .nf-core.yml is valid: pipeline
nfcore_yml - nf-core version in .nf-core.yml is set to the latest version: 3.2.0

Run details

nf-core/tools version 3.2.0
Run at 2025-04-15 06:18:16

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

sofstam · 2025-04-10T09:28:52Z

@nf-core-bot fix linting

…into porechop_abi

sofstam · 2025-04-10T09:44:57Z

@nf-core-bot fix linting

sofstam · 2025-04-10T11:50:19Z

@nf-core-bot fix linting

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

sofstam · 2025-04-11T09:28:26Z

@nf-core-bot fix linting

jfy133

One correction to usage.md and slight improvement to parameter doc but otherwise LGTM

jfy133 · 2025-04-14T10:16:17Z

 Both tools support length filtering of reads and can be tuned with `--shortread_qc_minlength`. Performing length filtering can be useful to remove short (often low sequencing complexity) sequences that result in unspecific classification and therefore slow down runtime during classification/profiling, with minimal gain.

 There are currently two options for long-read Oxford Nanopore processing: [`porechop`](https://github.com/rrwick/Porechop), [`porechop_abi`](https://github.com/bonsai-team/Porechop_ABI).
+You can enable on the `abi` option by turning on `--longread_qc_predictadapters` to predict adapters directly from the reads.


I think this needs it own subsection/eader as it is tool specific guidance (the rest seems to be generic), and also --longread_qc_predictadpaters doesn't tell it to use porechop_abi does it?

You are right, it does not explain that -longread_qc_predictadpaters uses porechop_abi. Making the docs more clear.

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

sofstam · 2025-04-14T12:59:25Z

@nf-core-bot fix linting

jfy133 · 2025-04-15T06:14:20Z

 You can also turn off clipping and only perform paired-end merging, if requested. This can be useful when processing data downloaded from the ENA, SRA, or DDBJ (`--shortread_qc_skipadaptertrim`).
 Both tools support length filtering of reads and can be tuned with `--shortread_qc_minlength`. Performing length filtering can be useful to remove short (often low sequencing complexity) sequences that result in unspecific classification and therefore slow down runtime during classification/profiling, with minimal gain.

+###### Long reads


Suggested change

###### Long reads

##### Long reads

jfy133 · 2025-04-15T06:16:33Z

Thank @LilyAnderssonLee @sofstam !

add params.longread_qc_predictadapters and params.longread_qc_adapter…

483d47f

…list to porechop_abi

LilyAnderssonLee changed the title ~~add params.longread_qc_predictadapters and params.longread_qc_adapter…~~ Add abi and custom adapters options to porechop_abi Mar 25, 2025

LilyAnderssonLee added 3 commits March 25, 2025 11:21

update changelog

fe80078

update moduels.config

d218522

udpate the docs

a02c645

LilyAnderssonLee and others added 4 commits March 25, 2025 11:56

update nextflow.config

aeadd26

correct the arguments of porechop_abi in modules.config

ea22b2c

udpate default for longread_qc_adapterlist in nextflow.config

ca5794c

update modules.config

7b623cb

LilyAnderssonLee requested review from jfy133 and sofstam March 25, 2025 14:42

sofstam reviewed Apr 3, 2025

View reviewed changes

Comment thread nextflow.config Outdated

jfy133 reviewed Apr 4, 2025

View reviewed changes

Comment thread conf/modules.config Outdated

Comment thread docs/output.md Outdated

Comment thread docs/output.md Outdated

Comment thread nextflow.config Outdated

sofstam and others added 3 commits April 8, 2025 15:18

Update nextflow.config

eb41335

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

Update conf/modules.config

a372365

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

Apply review suggestions

da4ed55

jfy133 requested changes Apr 10, 2025

View reviewed changes

Comment thread conf/modules.config Outdated

sofstam and others added 2 commits April 10, 2025 11:20

Update porechop_abi module

e33ccef

Merge branch 'crazy-corgi' into porechop_abi

1a3cada

nf-core-bot and others added 4 commits April 10, 2025 09:29

[automated] Fix code linting

2a842bf

Update workflow

8522934

Merge branch 'porechop_abi' of https://github.com/nf-core/taxprofiler …

4605210

…into porechop_abi

Fix linting

49c1534

nf-core-bot and others added 4 commits April 10, 2025 09:45

[automated] Fix code linting

3393d4a

Update porechop/abi module

9e9c68e

Fix conflicts

19c4735

Add custom_adapters as argument

a17e446

Update main workflow to include the custom adapters list

c334dde

[automated] Fix code linting

6e348e2

sofstam requested a review from jfy133 April 10, 2025 13:50

jfy133 reviewed Apr 11, 2025

View reviewed changes

Comment thread conf/modules.config Outdated

Comment thread docs/usage.md

Comment thread workflows/taxprofiler.nf Outdated

sofstam and others added 3 commits April 11, 2025 09:18

Update workflows/taxprofiler.nf

147493a

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

Update conf/modules.config

53d2093

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

Add example for custom adapter list

24f63a3

sofstam requested a review from jfy133 April 11, 2025 09:28

[automated] Fix code linting

48a22bb

jfy133 approved these changes Apr 14, 2025

View reviewed changes

sofstam and others added 4 commits April 14, 2025 13:22

Update docs/usage.md

8378103

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

Update nextflow_schema.json

07f94e0

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

Update docs for porechop abi

0a6a3a1

Split document into two sections

b00ea50

[automated] Fix code linting

dd531f0

jfy133 reviewed Apr 15, 2025

View reviewed changes

Comment thread docs/usage.md

jfy133 reviewed Apr 15, 2025

View reviewed changes

Comment thread nextflow_schema.json Outdated

jfy133 approved these changes Apr 15, 2025

View reviewed changes

Apply suggestions from code review

4b6fbb9

jfy133 merged commit daf5543 into crazy-corgi Apr 15, 2025

jfy133 deleted the porechop_abi branch April 15, 2025 06:16

Conversation

LilyAnderssonLee commented Mar 25, 2025

PR checklist

Uh oh!

github-actions Bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nf-core pipelines lint overall result: Passed ✅ ⚠️

❗ Test warnings:

✅ Tests passed:

Run details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sofstam commented Apr 10, 2025

Uh oh!

sofstam commented Apr 10, 2025

Uh oh!

sofstam commented Apr 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sofstam commented Apr 11, 2025

Uh oh!

jfy133 left a comment

Choose a reason for hiding this comment

Uh oh!

jfy133 Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

sofstam Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sofstam commented Apr 14, 2025

Uh oh!

jfy133 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jfy133 commented Apr 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Mar 25, 2025 •

edited

Loading

`nf-core pipelines lint` overall result: Passed ✅ ⚠️