Skip to content

Add significance filter for FIMO results #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LeonHafner merged 5 commits into from
Nov 19, 2025
Merged

Add significance filter for FIMO results #65

LeonHafner merged 5 commits into from
Nov 19, 2025

Conversation

@nictru
Copy link
Collaborator

@nictru nictru commented Nov 12, 2025

This is mainly done to prevent the report size from exploding. Thus, the unfiltered files are still stored in the results directory, but also the filtered one.

@nictru nictru requested a review from LeonHafner November 12, 2025 21:49
@nf-core-bot
Copy link
Member

nf-core-bot commented Nov 12, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 78a4054

+| ✅ 217 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   3 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-11-13 18:40:27

LeonHafner
LeonHafner reviewed Nov 19, 2025
View reviewed changes
nictru
nictru commented Nov 19, 2025
View reviewed changes
LeonHafner
LeonHafner approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@LeonHafner LeonHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me then!

@LeonHafner LeonHafner merged commit 32a583b into dev Nov 19, 2025
37 of 39 checks passed
@LeonHafner LeonHafner deleted the fimo-significant-filter branch November 19, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeonHafner LeonHafner LeonHafner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nictru @nf-core-bot @LeonHafner