fix: ng-doc-tab was being removed when using grouped code blocks on g… #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uide pages
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue
I've noticed that when using code block with group property, everything was working correctly in guide pages and api pages, unless it was used with
JsDoc.tagsaction. For example, creating following tsdoc:and then using
JsDocaction in markdown page:was rendering the example with the first tab being below the tab-group, instead of inside of it.
After analysing and debugging, I noticed that the code block was being removed from the
<ng-doc-tab>and placed in an external block after theprocessHtmlmethod was run fromprocess.html.ts. I tried removing each plugin, and it seems like there is a bug inunifieditself because no matter what I did, the HTML structure was still being changed. A fix that works and does not break any other functionality is to wrap the<ng-doc-tab>inside a<div>for building purposes, which is then removed bytabs.processor.Does this PR introduce a breaking change?
Other information