Skip to content

fix(store): guard against running state functions after injector is destroyed #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturovt merged 3 commits into from
Aug 31, 2025
Merged

fix(store): guard against running state functions after injector is destroyed #2366

arturovt merged 3 commits into from
Aug 31, 2025
+16 −3

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Aug 31, 2025

Adds a defensive check in the compose helper to ensure that no state
functions are executed once the root Injector has been destroyed.

Although the destroyed flag on Injector is not part of the public API,
it is available on the root injector instance. Using a cast here avoids the
need to inject ApplicationRef, which could introduce cyclic dependencies
or breaking changes.

This prevents runtime errors and unintended behavior when actions are
dispatched or state pipelines are invoked after application teardown.

@nx-cloud
Copy link

nx-cloud bot commented Aug 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8ce0870

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 13s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-31 18:29:56 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 31, 2025 •
edited
Loading

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2366

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2366

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2366

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2366

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2366

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2366

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2366

commit: 8ce0870

@arturovt arturovt marked this pull request as ready for review August 31, 2025 18:27
@bundlemon
Copy link

bundlemon bot commented Aug 31, 2025 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 103.83KB (+403B +0.38%) 105KB / +0.5%
Unchanged files (5)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 13.62KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.32KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change +403B +0.29%

Groups updated (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 33.6KB (+175B +0.51%) +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Aug 31, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.93KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.72KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.58KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.47KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.28KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Aug 31, 2025 •
edited
Loading

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng20/dist-integration/browser/mai
n-(hash).js
 67.15KB +1%

Total files change +7B +0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt merged commit 26e09f5 into master Aug 31, 2025
10 of 12 checks passed
@arturovt arturovt deleted the fix/guard-compose branch August 31, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturovt