docs(cache): invalidation using ocache#4216
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughDocumentation updated to document runtime cache invalidation methods: an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/1.docs/7.cache.md (1)
362-379: Includebasein theinvalidateCacheexample for consistency.On Line 362 and Line 378, the text says
basemust match, but the example on Line 367–Line 374 does not show it. Addingbaseinoptionswould make this safer for users with non-default cache mounts.Proposed doc tweak
await invalidateCache({ options: { name: "ghStars", group: "nitro/functions", + base: "cache", getKey: (repo: string) => repo, }, args: ["unjs/nitro"], });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/1.docs/7.cache.md` around lines 362 - 379, Update the invalidateCache example to include the base option so it matches the text and prevents mismatches for non-default cache mounts: modify the call to invalidateCache (the options object passed to invalidateCache) to include base alongside name, group, and getKey, ensuring the example shows the same base value users must match when defining the cached function.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/1.docs/7.cache.md`:
- Around line 362-379: Update the invalidateCache example to include the base
option so it matches the text and prevents mismatches for non-default cache
mounts: modify the call to invalidateCache (the options object passed to
invalidateCache) to include base alongside name, group, and getKey, ensuring the
example shows the same base value users must match when defining the cached
function.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f6458ab8-8dc0-4439-8489-a9792bcb93c8
📒 Files selected for processing (1)
docs/1.docs/7.cache.md
commit: |
🔗 Linked issue
Closes #3969
❓ Type of change
📚 Description
Updates cache invalidation to use ocache's new invalidation methods
📝 Checklist