feat(vercel): add back node entry format under a flag#3709
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro v3 migrated to web-api first and for runtimes not supporting it, we use
srx/nodecompatibility layer.With vercel web API handler format (not srvx),
req.node.{req,res}context is unavailable which makes issues in some cases like express streaming support.This PR adds back node.js handler format support under a flag
vercel.entryFormat: "node" | "web"to allow switching. (cc @nitrojs/vercel)TODO for later: one test if failing with runtime proxy, have to investigate later but likely is a setup issue i guess (+ a windows issue which is unrelavant)