feat: auto detect builder (optional rollup)#3769
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6e52b0a to
47f3387
Compare
|
|
||
| break; | ||
| // Auto-detect installed builder | ||
| for (const pkg of ["rolldown", "rollup", "vite"] as const) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
With vite, vite dev|build is used which explicitly sets builder itself:
nitro/src/build/vite/plugin.ts
Line 361 in 4cf1b53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro v3 now has 4 options of builders: rollup/rolldown/vite/rolldown-vite
This PR makes rollup an optional peer dep to allow choosing between options without imposing additional install size.