-
-
Notifications
You must be signed in to change notification settings - Fork 779
docs(v3): add versions menu #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdded a versions configuration array to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs/.config/docs.yaml(1 hunks)docs/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: tests-rolldown (windows-latest)
- GitHub Check: tests-rollup (windows-latest)
- GitHub Check: tests-rollup (ubuntu-latest)
🔇 Additional comments (1)
docs/.config/docs.yaml (1)
15-19: Theversionsarray structure is correct and matches the undocs configuration schema. The propertieslabel,active, andtoare all supported in undocs v0.4.11, and their usage here is proper:labelfor display text,activeto mark v3 as the current version, andtoto link v2 to the legacy docs at https://nitro.build.
| "devDependencies": { | ||
| "shaders": "^2.0.674", | ||
| "undocs": "^0.4.10" | ||
| "undocs": "^0.4.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
undocs 0.4.11 release changelog features versions menu
💡 Result:
Minetest 0.4.11 — release date: December 24, 2014. Key changelog items (high‑level): added mapgen v5 and enable_build_where_you_stand; inventory right‑click drag/drop; various visual/UI changes (video‑driver selection in settings, node highlighting, configurable selection‑box width, in‑game key‑change menu, removed screenshot alpha, etc.); gameplay tweaks and tweaks to dropped items/third‑person view; many other minor fixes and improvements. (olddev.minetest.org)
Citations:
🌐 Web query:
undocs npm package version 0.4.11
💡 Result:
I can't find an official npm release named undocs@0.4.11. The public undocs package latest listed is v0.4.10, while a "undocs‑nightly" package has a 0.4.11-... nightly build (0.4.11-20250925-130907-fa6d5d2). Sources: [Socket (undocs)] [1], [Socket (undocs‑nightly)] [2].
If you want, I can fetch the exact registry metadata/tarball info for a specific package name.
Remove or clarify undocs version reference — 0.4.11 does not exist as an official release.
The npm package undocs@0.4.11 is not available in the public npm registry. The latest official release is v0.4.10. Updating to ^0.4.11 will cause installation failures. Either revert to ^0.4.10 or switch to the undocs-nightly package if nightly builds are intended.
🤖 Prompt for AI Agents
In docs/package.json around line 9, the dependency "undocs": "^0.4.11"
references a non-existent release and will break installs; change it to a valid
version or the intended package: either update the version to "^0.4.10" (the
latest official release) or replace the dependency with "undocs-nightly" (or the
correct nightly package name) if nightly builds were intended, and run npm
install / yarn install to verify resolution.
Following #3855 so both websites links to each others + knowing the current major version from the header.