Skip to content

build!: remove nitro/deps/*#3878

Merged
pi0 merged 1 commit into
mainfrom
refactor/no-deps-subpath
Dec 16, 2025
Merged

build!: remove nitro/deps/*#3878
pi0 merged 1 commit into
mainfrom
refactor/no-deps-subpath

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Dec 16, 2025

nitro/deps/h3 and nitro/h3 introduced in first alpha however having both confuses IDE and makes inconsistent usage.

This PR removes nitro/deps/h3|ofetch and only keeps nitro/h3

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nitro.build Ready Ready Preview, Comment Dec 16, 2025 8:55am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 16, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes remove the public re-exports of internal dependencies (h3 and ofetch) from the package's API surface, including removal of export statements from module files and corresponding export mappings from package.json and the build resolver configuration.

Changes

Cohort / File(s) Summary
Module exports
lib/deps/ofetch.mjs, lib/deps/ofetch.mts		 Removed $fetch re-export statements from both module files
Package configuration
package.json		 Removed two export mappings from the exports map: ./deps/h3 and ./deps/ofetch
Build resolver
src/build/plugins/resolve.ts		 Removed two entries from subpathMap: nitro/deps/h3 and nitro/deps/ofetch

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • All changes follow a consistent pattern of removing internal dependency re-exports across multiple configuration layers
  • Changes are homogeneous (repetitive removal pattern) rather than heterogeneous logic changes
  • Key consideration: verify that no downstream code depends on the removed public API exports (./deps/h3 and ./deps/ofetch from package.json)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/no-deps-subpath
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98f5146 and b1cde0c.

📒 Files selected for processing (4)
  • lib/deps/ofetch.mjs (0 hunks)
  • lib/deps/ofetch.mts (0 hunks)
  • package.json (0 hunks)
  • src/build/plugins/resolve.ts (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pi0 pi0 merged commit c45e3a6 into main Dec 16, 2025
8 of 9 checks passed
@pi0 pi0 deleted the refactor/no-deps-subpath branch December 16, 2025 08:56
@coderabbitai coderabbitai Bot mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pi0