src/presets/cloudflare/runtime/cloudflare-durable.ts (1)

55-64: Logic looks correct for passing Cloudflare bindings to WebSocket handlers.

The implementation properly initializes request.context with Cloudflare bindings before delegating to the WebSocket upgrade handler. The use of Object.defineProperty with enumerable: true and the ||= operators ensure safe initialization.

However, this exact logic is duplicated in src/presets/cloudflare/runtime/cloudflare-module.ts (lines 28-37). Consider extracting this initialization into a shared helper function in _module-handler.ts to reduce duplication:

// In _module-handler.ts
function initializeWebSocketContext(
  request: Request,
  env: any,
  context: any
): void {
  let wsContext = (request as any).context;
  if (!wsContext) {
    wsContext = {};
    Object.defineProperty(request as any, "context", { 
      enumerable: true, 
      value: wsContext 
    });
  }
  wsContext.cloudflare ||= {};
  wsContext.cloudflare.env ||= env;
  wsContext.cloudflare.context ||= context;
}

Then use in both files:

initializeWebSocketContext(request, env, context);
return ws!.handleUpgrade(request, env, context);

Note: The comment stating "crossws will forward request.context to peer.context" may be inaccurate. According to crossws documentation, context should be forwarded via ctx.props (ExecutionContext properties) rather than request.context. Verify if the current approach actually works as intended or if context.props should be used instead.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.416Z
Learning: Applies to src/runtime/**/*.{ts,js} : In runtime code, prefer Web APIs (fetch, Request, Response, URL, etc.) over Node.js APIs

Learnt from: medz
Repo: nitrojs/nitro PR: 3834
File: src/presets/cloudflare/server-entry.ts:63-63
Timestamp: 2025-12-03T19:09:13.905Z
Learning: In the Nitro Cloudflare preset (src/presets/cloudflare/server-entry.ts), native errors from oxc-parser and Node.js readFile operations should be allowed to bubble up naturally without wrapping, as their native error messages are more user-friendly and provide better diagnostic information.

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.416Z
Learning: Applies to src/runtime/**/*.{ts,js} : Keep runtime code minimal and side-effect free to reduce bundle size

src/presets/cloudflare/runtime/_module-handler.ts (1)

81-149: Consider consolidating env exposure for non-fetch handlers.

The scheduled, email, queue, tail, and trace handlers all repeat (globalThis as any).__env__ = env; inline. Per the PR discussion, the goal was to call a shared utility from all entrypoints.

Since these handlers lack a request object, you could extract a minimal helper (e.g., exposeEnv(env)) or extend augmentContext to accept an optional request. This would reduce duplication and centralize the global env exposure pattern.

src/presets/cloudflare/runtime/cloudflare-pages.ts (1)

63-77: Consider using a shared env exposure helper for consistency.

The scheduled handler still has inline (globalThis as any).__env__ = env; (line 65), mirroring the pattern in _module-handler.ts. If you extract a shared helper for env exposure as suggested for the other handlers, this could be consolidated as well.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.435Z
Learning: Applies to src/runtime/**/*.{ts,js} : In runtime code, prefer Web APIs (fetch, Request, Response, URL, etc.) over Node.js APIs

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.435Z
Learning: Applies to src/runtime/**/*.{ts,js} : Keep runtime code minimal and side-effect free to reduce bundle size

Learnt from: medz
Repo: nitrojs/nitro PR: 3834
File: src/presets/cloudflare/server-entry.ts:63-63
Timestamp: 2025-12-03T19:09:13.905Z
Learning: In the Nitro Cloudflare preset (src/presets/cloudflare/server-entry.ts), native errors from oxc-parser and Node.js readFile operations should be allowed to bubble up naturally without wrapping, as their native error messages are more user-friendly and provide better diagnostic information.

src/presets/cloudflare/runtime/cloudflare-module.ts (1)

19-23: Parameter rename improves clarity.

The rename from request to cfRequest effectively signals that this is the Cloudflare-specific request parameter. The static assets delegation is correct.

However, the as any cast on line 22 reduces type safety. If the type mismatch is due to differences between the standard Request type and Cloudflare's extended request type, consider whether a more specific type assertion would be safer.

src/presets/cloudflare/runtime/cloudflare-durable.ts (1)

46-46: Consider more specific type assertions.

The as any casts reduce type safety. If these are necessary due to type mismatches between standard Request and Cloudflare's extended types, consider whether more specific type assertions would be safer and more maintainable.

Also applies to: 50-51

src/presets/cloudflare/runtime/_module-handler.ts (1)

24-25: LGTM! Request augmentation correctly positioned.

The augmentation at line 25 happens early in the fetch flow, ensuring all downstream handlers (including WebSocket upgrades and preset-specific logic) have access to the Cloudflare env and context. The simplified return at line 38 is cleaner.

The as any casts reduce type safety but may be necessary due to type system limitations between Web API types and Cloudflare-specific types.

Also applies to: 38-38

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.435Z
Learning: Applies to src/runtime/**/*.{ts,js} : In runtime code, prefer Web APIs (fetch, Request, Response, URL, etc.) over Node.js APIs

Learnt from: medz
Repo: nitrojs/nitro PR: 3834
File: src/presets/cloudflare/server-entry.ts:63-63
Timestamp: 2025-12-03T19:09:13.905Z
Learning: In the Nitro Cloudflare preset (src/presets/cloudflare/server-entry.ts), native errors from oxc-parser and Node.js readFile operations should be allowed to bubble up naturally without wrapping, as their native error messages are more user-friendly and provide better diagnostic information.

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.435Z
Learning: Applies to src/runtime/**/*.{ts,js} : Keep runtime code minimal and side-effect free to reduce bundle size

src/presets/cloudflare/runtime/_module-handler.ts (1)

113-126: Well-structured augmentation helper.

The augmentReq function correctly:

• Initializes the runtime object with fallback values
• Preserves existing cloudflare properties via spread (line 121)
• Binds waitUntil for proper async handling
• Supports both ExecutionContext and DurableObjectState

The multiple as any casts (lines 118, 122-123) bridge type systems between Cloudflare Workers types and internal types, which is necessary in this runtime boundary layer.

♻️ Optional: Consider stronger typing

If stricter typing would be valuable, you could define an explicit type guard or interface for ServerRequest with Cloudflare extensions:

interface CloudflareServerRequest extends ServerRequest {
  runtime: {
    name: string;
    cloudflare?: {
      env?: unknown;
      context?: CF.ExecutionContext | CF.DurableObjectState;
    };
  };
  waitUntil?: (promise: Promise<any>) => void;
}

export function augmentReq(
  cfReq: Request | CF.Request,
  env: unknown,
  context: CF.ExecutionContext | CF.DurableObjectState
) {
  const req = cfReq as CloudflareServerRequest;
  // ... rest of implementation
}

However, the current approach is pragmatic for runtime code where type boundaries are fluid.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.435Z
Learning: Applies to src/runtime/**/*.{ts,js} : In runtime code, prefer Web APIs (fetch, Request, Response, URL, etc.) over Node.js APIs

Learnt from: CR
Repo: nitrojs/nitro PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-24T11:45:17.435Z
Learning: Applies to src/runtime/**/*.{ts,js} : Keep runtime code minimal and side-effect free to reduce bundle size

Learnt from: medz
Repo: nitrojs/nitro PR: 3834
File: src/presets/cloudflare/server-entry.ts:63-63
Timestamp: 2025-12-03T19:09:13.905Z
Learning: In the Nitro Cloudflare preset (src/presets/cloudflare/server-entry.ts), native errors from oxc-parser and Node.js readFile operations should be allowed to bubble up naturally without wrapping, as their native error messages are more user-friendly and provide better diagnostic information.