Better retention#139
Merged
Merged
Conversation
07593c8 to
ba445ca
Compare
974cf82 to
d48de7a
Compare
d3c22bf to
c169bc1
Compare
ce1af0c to
55bf014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to provide a better generation/deployment/profile retention support.
It allows to specify the number of deployment and boot entry to keep. A documentation explains how it works.
How to test this:
comin deployment list --bootto get the list of deployments which lead to boot menu entrybootctl listto ensure you get the expected number of deploymentsThe behavior is explained in https://github.com/nlewo/comin/blob/better-retention/docs/howtos.md#deployments-and-profiles-retention-policy
This can be configured with options https://github.com/nlewo/comin/blob/better-retention/docs/generated-module-options.md#servicescominretention
Warning: i'm a bit afraid by merging this since it's hard to test in the real world... So, if there are some volonteers to beta test this MR, that would be really useful! Note it's running since few days on all my machines.