I hope I managed to incorporate all requested changes now.

Anything else I can help with to get this merged?

wow, i don't understand why the Nix check is failing while it works on my machine 😢

It seems like now it passed. Which does not make it any less weird.

I clicked on rerun, and it worked. As you say, it's weird.

Anyway, thank you for this contribution!

hm, i realize that we forgot to add an option in the comin module to allow the user to set a post deployment command :/

@tcurdt I'm wondering how do you use this feature, or why you don't use the provided comin NixOS module?

hm, i realize that we forgot to add an option in the comin module to allow the user to set a post deployment command :/

Darn! You are right.

@tcurdt I'm wondering how do you use this feature, or why you don't use the provided comin NixOS module?

I can only use it once it's in stable. So for now I am just waiting for it and not using it yet.
That explains why I didn't noticed this yet. Glad you did.
We should fix that.

Do we want it like this? Not sure about the null case.

      postDeploymentCommand = mkOption {
        type = types.nullOr types.str;
        default = null;
        description = ''
          Path to the command to execute after a deploy.
          It provides some details on the deploy via env variables.
        '';
      };

I can only use it once it's in stable.

What do you mean by "stable"? In a NixOS release? Because comin is currently not part of nixpkgs 😅

Do we want it like this? Not sure about the null case.

Yes, and this could be refined in a PR. (i think there is a types.path type and we could also provide all environment variables names)

What do you mean by "stable"? In a NixOS release? Because comin is currently not part of nixpkgs 😅

Ups. That could have been a bit of a wait then 😅
Yup, it's an input to my flake.

Yes, and this could be refined in a PR. (i think there is a types.path type and we could also provide all environment variables names)

OK, let's do that.

@tcurdt I submitted #87