Skip to content

chore: cleaner fetch paths for slugs #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bmschmidt wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: cleaner fetch paths for slugs #371

bmschmidt wants to merge 1 commit into from

Conversation

@bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Jan 11, 2025 •
edited
Loading

Suggested changes to dataset fetching. Goals are:

  1. Preserve current behavior;
  2. Add deprecation warning to the the behavior that depends on passing slugs without an org name, because this magic keeps biting people.
  3. Throw http errors directly instead of assuming things couldn't be found.

@bmschmidt Graphite App
Copy link
Collaborator Author

bmschmidt commented Jan 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bmschmidt bmschmidt changed the title cleaner fetch paths for slugs chore: cleaner fetch paths for slugs Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcembalest mcembalest Awaiting requested review from mcembalest

@wilson-nomic wilson-nomic Awaiting requested review from wilson-nomic

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmschmidt