qml: improve chats with missing models and model settings layout #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Collaborator
|
This is marked as draft. Do you want review? |
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Collaborator
|
Can you show before/after of the model settings for the problem this fixes? |
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
manyoso
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improved handling of chats with missing models and enhanced layout of model settings in
ChatView.qmlandModelSettings.qml.Key points:
currentModelInstalledfunction ingpt4all-chat/qml/ChatView.qmlto check if the current model is installed.gpt4all-chat/qml/ChatView.qmlto usecurrentModelInstalled.gpt4all-chat/qml/ChatView.qml.gpt4all-chat/qml/ModelSettings.qmlfor better alignment and spacing.gpt4all-chat/qml/ModelSettings.qml.Generated with ❤️ by ellipsis.dev