Skip to content

Sequel adapter#89

Open
jfirebaugh wants to merge 2 commits into
notahat:masterfrom
bigfix:sequel
Open

Sequel adapter#89
jfirebaugh wants to merge 2 commits into
notahat:masterfrom
bigfix:sequel

Conversation

@jfirebaugh

Copy link
Copy Markdown

I added a Sequel adapter.

Since Sequel doesn't support deferred associations natively, the adapter is slightly more complex than the ActiveRecord adapter.

@matthauck

Copy link
Copy Markdown

Is it possible to get this merged in? It would be really nice to have Sequel support in machinist...

@benhoskings

Copy link
Copy Markdown
Collaborator

This would be better packaged as a separate gem, perhaps machinist-sequel—it's cleanly independent of machinist core and this way, the mainenance of one won't affect the other.

@matthauck

Copy link
Copy Markdown

Seeing as ActiveRecord is supported as an adapter already, and not really part of the "core", is it not reasonable to have Sequel also supported in the main gem?

@benhoskings

Copy link
Copy Markdown
Collaborator

Well, activerecord should be moved to a separate gem too, but that's a separate job :)

Since the two concerns can be cleanly separated I think separate gems would be better.

On 28/01/2013, at 6:07 PM, Matt Hauck notifications@github.com wrote:

Seeing as ActiveRecord is supported as an adapter already, and not really part of the "core", is it not reasonable to have Sequel also supported in the main gem?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants