Fix: strip _any_ trailing line break character from the titles #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, when parsing *.md files with windows-style line breaks (CR-LF), one of the line break characters would remain in the title, thus breaking the markup for the table of content.
Author
|
@npryce would appreciate a feedback on this one, thank you. |
Author
|
@npryce sorry for bumping this, but would be really helpful if this could be merged, it's painful to get this fixed locally on each and every windows host where I need to run adr-tools. |
Author
|
@npryce hi, is there any chance to get a feedback on this one? Thank you. |
Author
|
@npryce any chance to get this reviewed? thanks! |
halostatue
pushed a commit
to halostatue/adr-tools
that referenced
this pull request
Jul 20, 2024
Otherwise, when parsing *.md files with windows-style line breaks (CR-LF), one of the line break characters would remain in the title, thus breaking the markup for the table of content. npryce#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when parsing *.md files with windows-style line breaks (CR-LF), one of the line break characters would remain in the title, thus breaking the markup for the table of content.