feat(web): remove deprecated executors#16416
Merged
FrozenPandaz merged 1 commit intoApr 20, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
approved these changes
Apr 19, 2023
Member
|
@jaysoo Can we rerun the migration that moves people to use the new executors? |
FrozenPandaz
requested changes
Apr 19, 2023
FrozenPandaz
left a comment
Contributor
There was a problem hiding this comment.
Can you take a look at this line please?
It's being generated in @nx/react-native
Contributor
3e62ca0 to
6255677
Compare
6255677 to
5ffe60f
Compare
dda54a9 to
965fe22
Compare
Member
Author
Sure, we can do it a third time. 😅 |
965fe22 to
056adbf
Compare
e92a544 to
1b3fdc7
Compare
AgentEnder
approved these changes
Apr 19, 2023
1b3fdc7 to
d986171
Compare
barbados-clemens
approved these changes
Apr 19, 2023
d986171 to
e8384da
Compare
nartc
approved these changes
Apr 19, 2023
FrozenPandaz
left a comment
Contributor
There was a problem hiding this comment.
Sorry, could you also add redirects for nx.dev?
Coly010
approved these changes
Apr 20, 2023
mandarini
approved these changes
Apr 20, 2023
e8384da to
eca3160
Compare
eca3160 to
39087ba
Compare
39087ba to
3300a29
Compare
xiongemi
approved these changes
Apr 20, 2023
3300a29 to
5d16c91
Compare
bcabanes
approved these changes
Apr 20, 2023
5d16c91 to
4e409bd
Compare
4e409bd to
8cbcdb3
Compare
8cbcdb3 to
48f51ca
Compare
48f51ca to
9dd476a
Compare
FrozenPandaz
approved these changes
Apr 20, 2023
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes executors that we deprecated back in Nx 13 :
@nrwl/web:rollup,@nrwl/web:webpack,@nrwl/web:dev-server,@nrwl/node:webpack. The migrations were applied back in Nx 14 and Nx 15, so people have had enough time to adapt.Notes
@nx/web:rollupwith@nx/rollup:rollup(some were tests or test fixtures)