Skip to content

fix(release): allow version plans to have multi-line, arbitrarily formatted messages#27323

Merged
JamesHenry merged 3 commits into
masterfrom
version-plans-messages
Aug 7, 2024
Merged

fix(release): allow version plans to have multi-line, arbitrarily formatted messages#27323
JamesHenry merged 3 commits into
masterfrom
version-plans-messages

Conversation

@JamesHenry

@JamesHenry JamesHenry commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

Current Behavior

In order to land experimental version plans support, we temporarily kept the changelog messages coupled to conventional commits, even though they really should be completely unrelated.

Expected Behavior

Messages in version plans are not constrained to be single line conventional commit style messages. They can have any structure and be of any length (including newlines).

The nx release plan command now helpfully provides an interactive editor experience for the message if you submit an empty value (the prompt explains this inline).

Related Issue(s)

Fixes #

@vercel

vercel Bot commented Aug 7, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 7, 2024 8:43pm

@nx-cloud

nx-cloud Bot commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

fahslaj
fahslaj previously requested changes Aug 7, 2024
Comment thread packages/nx/src/command-line/release/changelog.ts Outdated
@JamesHenry JamesHenry marked this pull request as ready for review August 7, 2024 20:34
@JamesHenry JamesHenry requested a review from a team as a code owner August 7, 2024 20:34
@JamesHenry JamesHenry requested a review from AgentEnder August 7, 2024 20:34
@JamesHenry JamesHenry enabled auto-merge (squash) August 7, 2024 20:37
@JamesHenry JamesHenry removed the request for review from AgentEnder August 7, 2024 20:50
@JamesHenry JamesHenry merged commit 7e22661 into master Aug 7, 2024
@JamesHenry JamesHenry deleted the version-plans-messages branch August 7, 2024 21:27
ZackDeRose pushed a commit to ZackDeRose/nx that referenced this pull request Aug 8, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants