feat(release)!: releasePublish always returns status code per project#28224
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ef25d35. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
JamesHenry
commented
Oct 1, 2024
| loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false', | ||
| } | ||
| ); | ||
| if (status !== 0) { |
Contributor
Author
There was a problem hiding this comment.
This never actually did anything after the throw was added at some point
JamesHenry
commented
Oct 1, 2024
| loadDotEnvFiles: process.env.NX_LOAD_DOT_ENV_FILES !== 'false', | ||
| } | ||
| ); | ||
| if (status !== 0) { |
Contributor
Author
There was a problem hiding this comment.
This never actually did anything after the throw was added at some point
jaysoo
approved these changes
Oct 2, 2024
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
In v19 of nx, the programmatic usage of
await releasePublish({ ... })would throw in the case that any project failed to publish. It would return the number0(to represent the overall exit code) in the case that all projects were successfully published.Now, in v20, the programmatic usage of
await releasePublish({ ... })will always return aPublishProjectsResultobject, which is a mapping of project names to an object of{ code: number }for each project. This allows consumers to make informed decisions about which projects failed to publish and decide how to handle it in their release scripts.For example, where there are projects called "pkg-a" and "pkg-b" and "pkg-a" is successfully published and "pkg-b" fails: