Skip to content

feat(testing): split atomized outputs for Playwright and Cypress CI targets#28682

Merged
jaysoo merged 1 commit into
masterfrom
feat/atomizer-outputs
Oct 31, 2024
Merged

feat(testing): split atomized outputs for Playwright and Cypress CI targets#28682
jaysoo merged 1 commit into
masterfrom
feat/atomizer-outputs

Conversation

@jaysoo

@jaysoo jaysoo commented Oct 29, 2024

Copy link
Copy Markdown
Member

This PR updates @nx/playwright/plugin to create non-conflicting outputs for atomized tasks.

Current Behavior

Outputs from outputDir and reporters are the same for each atomized task, which results in missing outputs.

Expected Behavior

All outputs should be captured and cached correctly.

Related Issue(s)

Fixes #

@vercel

vercel Bot commented Oct 29, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 1:39pm

@nx-cloud

nx-cloud Bot commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

@jaysoo jaysoo force-pushed the feat/atomizer-outputs branch 3 times, most recently from 47ffe95 to 017d55a Compare October 29, 2024 20:26
@jaysoo jaysoo changed the title feat(testing): split atomized outputs for Playwright CI targets feat(testing): split atomized outputs for Playwright and Cypress CI targets Oct 29, 2024
@github-actions

Copy link
Copy Markdown
Contributor

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-28682-017d55a my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28682-017d55a
Release details 📑
Published version 0.0.0-pr-28682-017d55a
Triggered by @jaysoo
Branch feat/atomizer-outputs
Commit 017d55a
Workflow run 11593407181

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@jaysoo jaysoo force-pushed the feat/atomizer-outputs branch from 017d55a to f05f746 Compare October 30, 2024 13:36
@github-actions

Copy link
Copy Markdown
Contributor

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-28682-f05f746 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28682-f05f746
Release details 📑
Published version 0.0.0-pr-28682-f05f746
Triggered by @jaysoo
Branch feat/atomizer-outputs
Commit f05f746
Workflow run 11594353561

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@jaysoo jaysoo marked this pull request as ready for review October 30, 2024 16:12
@jaysoo jaysoo requested a review from a team as a code owner October 30, 2024 16:12
@jaysoo jaysoo requested a review from FrozenPandaz October 30, 2024 16:12
@jaysoo jaysoo merged commit e22d65e into master Oct 31, 2024
@jaysoo jaysoo deleted the feat/atomizer-outputs branch October 31, 2024 13:40
@github-actions

github-actions Bot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants