fix(js): update detection of ts solution setup#29576
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 2431f68.
☁️ Nx Cloud last updated this comment at |
ndcunningham
approved these changes
Jan 9, 2025
ede7b21 to
2431f68
Compare
Coly010
approved these changes
Jan 9, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we simplified
tsconfig.base.json'scompilerOptionsto not include values that match defaults (as per Jake's feedback), the logic to detect TS solution setup should check thatdeclarationis explicitly set tofalse, rather than that it is falsy.Clean up PR: #29550
Current Behavior
We're not detecting TS solution setup correctly
Expected Behavior
Detection works
Related Issue(s)
Fixes #