fix(angular): directory type is not optional#30354
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 56a13f8.
☁️ Nx Cloud last updated this comment at |
2d1c0b6 to
56a13f8
Compare
Coly010
approved these changes
Mar 13, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 14, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The `directory` option for the ngrx feature store generator is currently marked as optional. With that, if you try to run the generator and do not pass a directory, it will throw an error. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `directory` needs to be a required option. The Nx Console already handles this by pre-populating the option, this just adjusts things appropriately for those not using the console, or calling the generator programatically. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 6770636)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
directoryoption for the ngrx feature store generator is currently marked as optional. With that, if you try to run the generator and do not pass a directory, it will throw an error.Expected Behavior
directoryneeds to be a required option. The Nx Console already handles this by pre-populating the option, this just adjusts things appropriately for those not using the console, or calling the generator programatically.Related Issue(s)
Fixes #