feat(release)!: switch defaults for fixed release group tag pattern, preserve matching dependency ranges and strictPreid#32878
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 2882c44
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2b05de7 to
bb50aa3
Compare
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bb50aa3 to
d3885e4
Compare
FrozenPandaz
approved these changes
Sep 30, 2025
d3885e4 to
7e2e7c4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
7e2e7c4 to
bfeea77
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bfeea77 to
6e51519
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
6e51519 to
ff67745
Compare
Contributor
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We've updated the e2e tests to reflect the new default behaviors introduced in this breaking change. The tests now correctly expect: (1) fixed release group tags to use the pattern {releaseGroupName}-v{version}, (2) strict preid matching by default when resolving git tags, and (3) no CHANGELOG.md files in publish tarballs since they're not created by the npm-package generator. These changes ensure the test suite accurately validates the updated release configuration defaults.
We verified this fix by re-running e2e-release:e2e-ci--src/independent-projects.test.ts.
Suggested Fix changes
diff --git a/e2e/release/src/independent-projects.test.ts b/e2e/release/src/independent-projects.test.ts
index 0e43b666b2..ac0d72bc58 100644
--- a/e2e/release/src/independent-projects.test.ts
+++ b/e2e/release/src/independent-projects.test.ts
@@ -390,7 +390,7 @@ describe('nx release - independent projects', () => {
Tagging the current commit in git with the following command:
git tag --annotate {project-name}@999.9.9-version-git-operations-test.3 --message {project-name}@999.9.9-version-git-operations-test.3
Tagging the current commit in git with the following command:
- git tag --annotate fixed-v999.9.9-version-git-operations-test.3 --message v999.9.9-version-git-operations-test.3
+ git tag --annotate fixed-v999.9.9-version-git-operations-test.3 --message fixed-v999.9.9-version-git-operations-test.3
`);
@@ -664,7 +664,6 @@ describe('nx release - independent projects', () => {
📦 @proj/{project-name}@X.X.X-dry-run
=== Tarball Contents ===
- XXXB CHANGELOG.md
XXB index.js
XXXB package.json
XXB project.json
@@ -676,7 +675,7 @@ describe('nx release - independent projects', () => {
unpacked size: XXXB
shasum: {SHASUM}
integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
- total files: 4
+ total files: 3
Would publish to http://localhost:4873 with tag "latest", but [dry-run] was set
@@ -713,7 +712,6 @@ describe('nx release - independent projects', () => {
📦 @proj/{project-name}@X.X.X-dry-run
=== Tarball Contents ===
- XXXB CHANGELOG.md
XXB index.js
XXXB package.json
XXB project.json
@@ -725,7 +723,7 @@ describe('nx release - independent projects', () => {
unpacked size: XXXB
shasum: {SHASUM}
integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
- total files: 4
+ total files: 3
Would publish to http://localhost:4873 with tag "latest", but [dry-run] was set
@@ -750,7 +748,6 @@ describe('nx release - independent projects', () => {
📦 @proj/{project-name}@X.X.X-dry-run
=== Tarball Contents ===
- XXXB CHANGELOG.md
XXB index.js
XXXB package.json
XXB project.json
@@ -762,7 +759,7 @@ describe('nx release - independent projects', () => {
unpacked size: XXXB
shasum: {SHASUM}
integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
- total files: 4
+ total files: 3
Would publish to http://localhost:4873 with tag "latest", but [dry-run] was set
@@ -795,7 +792,6 @@ describe('nx release - independent projects', () => {
📦 @proj/{project-name}@X.X.X-dry-run
=== Tarball Contents ===
- XXXB CHANGELOG.md
XXB index.js
XXXB package.json
XXB project.json
@@ -807,7 +803,7 @@ describe('nx release - independent projects', () => {
unpacked size: XXXB
shasum: {SHASUM}
integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
- total files: 4
+ total files: 3
Would publish to http://localhost:4873 with tag "latest", but [dry-run] was set
@@ -817,7 +813,6 @@ describe('nx release - independent projects', () => {
📦 @proj/{project-name}@X.X.X-dry-run
=== Tarball Contents ===
- XXXB CHANGELOG.md
XXB index.js
XXXB package.json
XXB project.json
@@ -829,7 +824,7 @@ describe('nx release - independent projects', () => {
unpacked size: XXXB
shasum: {SHASUM}
integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
- total files: 4
+ total files: 3
Would publish to http://localhost:4873 with tag "latest", but [dry-run] was set
@@ -859,7 +854,6 @@ describe('nx release - independent projects', () => {
📦 @proj/{project-name}@X.X.X-dry-run
=== Tarball Contents ===
- XXXB CHANGELOG.md
XXB index.js
XXXB package.json
XXB project.json
@@ -871,7 +865,7 @@ describe('nx release - independent projects', () => {
unpacked size: XXXB
shasum: {SHASUM}
integrity: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
- total files: 4
+ total files: 3
Would publish to http://localhost:4873 with tag "latest", but [dry-run] was set
diff --git a/e2e/release/src/release-tag-pattern.test.ts b/e2e/release/src/release-tag-pattern.test.ts
index 16c458a833..a7544ac0f0 100644
--- a/e2e/release/src/release-tag-pattern.test.ts
+++ b/e2e/release/src/release-tag-pattern.test.ts
@@ -61,6 +61,7 @@ describe('nx release releaseTagPattern', () => {
updateJson<NxJsonConfiguration>('nx.json', (nxJson) => {
nxJson.release = {
releaseTagPattern: 'v{version}',
+ releaseTagPatternStrictPreid: false,
version: {
conventionalCommits: true,
},
diff --git a/e2e/release/src/source-tag-selection.test.ts b/e2e/release/src/source-tag-selection.test.ts
index 2734cbd9df..ccde286eb3 100644
--- a/e2e/release/src/source-tag-selection.test.ts
+++ b/e2e/release/src/source-tag-selection.test.ts
@@ -71,7 +71,7 @@ describe('nx release source tag selection', () => {
});
describe('when no preid is specified', () => {
- it('uses the latest tag as source', async () => {
+ it('uses the latest stable tag as source', async () => {
await runCommandAsync(`git tag -a v1.0.0 -m "v1.0.0"`);
await runCommandAsync(`git tag -a v2.0.0-beta.1 -m "v2.0.0-beta.1"`);
await runCommandAsync(`git tag -a v2.0.0 -m "v2.0.0"`);
@@ -82,13 +82,13 @@ describe('nx release source tag selection', () => {
silenceError: true,
})
).toContain(
- `Resolved the current version as 3.0.0-beta.1 from git tag "v3.0.0-beta.1"`
+ `Resolved the current version as 2.0.0 from git tag "v2.0.0"`
);
});
});
describe('when a preid is specified', () => {
- it('uses the latest tag as source', async () => {
+ it('uses the latest stable tag as source', async () => {
await runCommandAsync(`git tag -a v1.0.0 -m "v1.0.0"`);
await runCommandAsync(`git tag -a v2.0.0-beta.1 -m "v2.0.0-beta.1"`);
await runCommandAsync(`git tag -a v2.0.0 -m "v2.0.0"`);
@@ -99,7 +99,7 @@ describe('nx release source tag selection', () => {
silenceError: true,
})
).toContain(
- `Resolved the current version as 3.0.0-beta.1 from git tag "v3.0.0-beta.1"`
+ `Resolved the current version as 2.0.0 from git tag "v2.0.0"`
);
});
});
diff --git a/packages/angular-rspack-compiler/package.json b/packages/angular-rspack-compiler/package.json
index 164423cb75..ae02aad3a1 100644
--- a/packages/angular-rspack-compiler/package.json
+++ b/packages/angular-rspack-compiler/package.json
@@ -1,7 +1,7 @@
{
"name": "@nx/angular-rspack-compiler",
"private": false,
- "version": "0.0.1",
+ "version": "22.0.0",
"publishConfig": {
"access": "public"
},
diff --git a/packages/angular-rspack/package.json b/packages/angular-rspack/package.json
index bd24ec75b0..fc933a089e 100644
--- a/packages/angular-rspack/package.json
+++ b/packages/angular-rspack/package.json
@@ -1,6 +1,6 @@
{
"name": "@nx/angular-rspack",
- "version": "0.0.1",
+ "version": "22.0.0",
"private": false,
"publishConfig": {
"access": "public"
@@ -49,8 +49,8 @@
"@ampproject/remapping": "2.3.0",
"@babel/core": "7.28.3",
"@discoveryjs/json-ext": "0.6.3",
- "@nx/angular-rspack-compiler": "workspace:*",
- "@nx/devkit": "workspace:*",
+ "@nx/angular-rspack-compiler": "22.0.0",
+ "@nx/devkit": "22.0.0",
"ansi-colors": "4.1.3",
"autoprefixer": "10.4.21",
"deepmerge": "^4.3.1",
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
0d9280c to
8ac1cd0
Compare
d7c3a7c to
5f10982
Compare
…preserve matching dependency ranges and strictPreid
5f10982 to
12d4514
Compare
12d4514 to
abc719d
Compare
abc719d to
874f28f
Compare
874f28f to
2882c44
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour changes introduced:
preserveMatchingDependencyRangesset totrueby defaultreleaseTagPatternStrictPreidset totrueby defaultreleaseTagPatternfor fixed release groups set to{releaseGroupName}-v{version}BREAKING CHANGE