fix(core): resolve lockfile cache regression with keyMap state#33448
Merged
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 440e4da
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Nov 11, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 14, 2025
After PR #33256 split lockfile parsing into separate node and dependency caches, a regression occurred where dependencies could be regenerated without nodes, leaving a shared module-level variable (`keyMap`) empty and causing incorrect dependency resolution. Changes: - Serialize `keyMap` with nodes cache to maintain state between phases - Remove module-level shared state from pnpm, npm, and yarn parsers - Move `keyMap` creation inside `getNodes` functions for better encapsulation - Update `readCachedExternalNodes` to deserialize `keyMap` internally (cherry picked from commit 8f3b0b2)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #33256 split lockfile parsing into separate node and dependency caches, a regression occurred where dependencies could be regenerated without nodes, leaving a shared module-level variable (
keyMap) empty and causing incorrect dependency resolution.Changes:
keyMapwith nodes cache to maintain state between phaseskeyMapcreation insidegetNodesfunctions for better encapsulationreadCachedExternalNodesto deserializekeyMapinternally