fix(js): remove redundant typescript project references #33438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit ea344be
☁️ Nx Cloud last updated this comment at |
joshvanallen
approved these changes
Nov 12, 2025
jaysoo
approved these changes
Nov 12, 2025
718e449 to
ea344be
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 12, 2025
## Current Behavior The `@nx/js:typescript-sync` generator adds project dependencies as TypeScript project references to each project's `tsconfig.json` and runtime tsconfig file (e.g., `tsconfig.app.json`, `tsconfig.lib.json`, etc.). This is redundant since projects' `tsconfig.json` files already reference the runtime tsconfig file, which would reference the dependencies. ## Expected Behavior The `@nx/js:typescript-sync` generator should add project dependencies as TypeScript project references to each project's runtime tsconfig file (e.g., `tsconfig.app.json`, `tsconfig.lib.json`, etc.). If the project only has a `tsconfig.json` file, it should add them to it. We've observed some performance improvement with this change while running the `typecheck` tasks.
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/js:typescript-syncgenerator adds project dependencies as TypeScript project references to each project'stsconfig.jsonand runtime tsconfig file (e.g.,tsconfig.app.json,tsconfig.lib.json, etc.). This is redundant since projects'tsconfig.jsonfiles already reference the runtime tsconfig file, which would reference the dependencies.Expected Behavior
The
@nx/js:typescript-syncgenerator should add project dependencies as TypeScript project references to each project's runtime tsconfig file (e.g.,tsconfig.app.json,tsconfig.lib.json, etc.). If the project only has atsconfig.jsonfile, it should add them to it.We've observed some performance improvement with this change while running the
typechecktasks.