fix(core): avoid leaking memory due by creating an unref'd interval for each daemon connection #33532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…or each daemon connection
cd4e25c to
054fc9a
Compare
Contributor
|
View your CI Pipeline Execution ↗ for commit 054fc9a
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Nov 19, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Every time a daemon connection is opened, we create a new interval and unref it. This results in the daemon checking its process termination at an ever increasing rate, which presents as increased memory usage and practically means the daemon is just doing a lot more work than it needs to in this area.
Expected Behavior
The interval is registered only on initial server startup.
Related Issue(s)
Fixes #29836