fix(js): prevent crash when terminating task using the @nx/js:swc executor#33845
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit c07b587
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Important
A new CI pipeline execution was requested that may update the conclusion below...
Nx Cloud has identified a possible root cause for your failed CI:
Our analysis shows the failing e2e test doesn't use the @nx/js:swc executor that was modified in this PR. The timeout occurs during environment-dependent setup operations (pnpm install, git commands) and cannot be logically connected to the PR's changes to swc's signal handling. This appears to be an environmental issue rather than a code change problem.
No code changes were suggested for this issue.
If the issue was transient, you can trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
…xecutor (#33845) ## Current Behavior When terminating a task using the `@nx/js:swc` executor before it ever got to execute its post-compilation logic, a `TypeError: disposeFn is not a function` error is thrown. ## Expected Behavior Terminating a task using the `@nx/js:swc` executor should not error. ## Related Issue(s) Fixes #31938 (cherry picked from commit 80523ef)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When terminating a task using the
@nx/js:swcexecutor before it ever got to execute its post-compilation logic, aTypeError: disposeFn is not a functionerror is thrown.Expected Behavior
Terminating a task using the
@nx/js:swcexecutor should not error.Related Issue(s)
Fixes #31938