Skip to content

fix(angular): ensure jest and jest-preset-angular are updated correctly for angular v21#33896

Merged
FrozenPandaz merged 1 commit into
masterfrom
nxc-3626
Dec 17, 2025
Merged

fix(angular): ensure jest and jest-preset-angular are updated correctly for angular v21#33896
FrozenPandaz merged 1 commit into
masterfrom
nxc-3626

Conversation

@leosvelperez

Copy link
Copy Markdown
Member

Current Behavior

There's a deadlock between the Angular and Jest package updates requirements (requires and incompatibleWith) that prevents updating Jest to v30 and jest-preset-angular to v16.

Expected Behavior

Updating to Angular v21 should result in updating Jest to v30 and jest-preset-angular to v16.

This is ensured by moving the jest-preset-angular package update definition to the @nx/jest package and processing the @nx/angular package updates before @nx/jest. That way, by the time @nx/jest is processed, the migrator would have collected the Angular v21 updates, and the requirements will be met.

@leosvelperez leosvelperez self-assigned this Dec 17, 2025
@leosvelperez leosvelperez requested review from a team as code owners December 17, 2025 09:50
@vercel

vercel Bot commented Dec 17, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Dec 17, 2025 9:50am

@nx-cloud

nx-cloud Bot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1483641

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 7m 8s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 36s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-17 13:48:21 UTC

@netlify

netlify Bot commented Dec 17, 2025

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 1483641
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69427cf849cce2000837b99e
😎 Deploy Preview https://deploy-preview-33896--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@FrozenPandaz FrozenPandaz merged commit c29834c into master Dec 17, 2025
22 of 24 checks passed
@FrozenPandaz FrozenPandaz deleted the nxc-3626 branch December 17, 2025 13:48
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants