Skip to content

feat(webpack): add support for merging externals to NxAppWebpackPlugin#33833

Merged
Coly010 merged 4 commits into
masterfrom
kiwiapps-ltd/master
Dec 12, 2025
Merged

feat(webpack): add support for merging externals to NxAppWebpackPlugin#33833
Coly010 merged 4 commits into
masterfrom
kiwiapps-ltd/master

Conversation

@Coly010

@Coly010 Coly010 commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces a new option to the Nx Webpack plugin that allows users to control whether the plugin should merge its external dependencies configuration with any existing Webpack externals configuration. This provides greater flexibility when customizing how external dependencies are handled during the build process.

Configuration enhancements:

  • Added a new mergeExternals boolean option to the NxAppWebpackPluginOptions interface, allowing users to specify whether to combine the plugin's externals configuration with the existing Webpack config.
  • Updated the logic in apply-base-config.ts so that the externals array is set based on the new mergeExternals option, defaulting to not merging unless specified.

@Coly010 Coly010 requested a review from a team as a code owner December 12, 2025 11:06
@Coly010 Coly010 requested a review from JamesHenry December 12, 2025 11:06
@Coly010 Coly010 self-assigned this Dec 12, 2025
@vercel

vercel Bot commented Dec 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Dec 12, 2025 11:33am

@netlify

netlify Bot commented Dec 12, 2025

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 392617a
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/693bfc0914ac2b0008d124ca
😎 Deploy Preview https://deploy-preview-33833--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 392617a

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 23m 13s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 22s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-12 11:55:31 UTC

Comment thread packages/webpack/src/plugins/nx-webpack-plugin/nx-app-webpack-plugin-options.ts Outdated
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@Coly010 Coly010 merged commit 1409648 into master Dec 12, 2025
20 checks passed
@Coly010 Coly010 deleted the kiwiapps-ltd/master branch December 12, 2025 12:03
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants