fix(module-federation): skip non-npm external dependencies in getDependencies #33951
+68
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies The getDependentPackagesForProject function was crashing when processing projects with non-npm external nodes (e.g., cargo: prefixed nodes from @monodon/rust plugin). The code only handled npm: prefixed externals and treated everything else as workspace libraries, causing undefined access errors when cargo externals were encountered. This fix adds a check to skip external nodes that aren't npm-prefixed by detecting the presence of a colon in the dependency target. Only npm: prefixed externals are processed as npm packages, and other external prefixes (cargo:, maven:, etc.) are now properly skipped. Fixes #32819
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 91ed9d2
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Dec 19, 2025
jaysoo
pushed a commit
that referenced
this pull request
Dec 19, 2025
…ndencies (#33951) The getDependentPackagesForProject function was crashing when processing projects with non-npm external nodes (e.g., cargo: prefixed nodes from @monodon/rust plugin). The code only handled npm: prefixed externals and treated everything else as workspace libraries, causing undefined access errors when cargo externals were encountered. This fix adds a check to skip external nodes that aren't npm-prefixed by detecting the presence of a colon in the dependency target. Only npm: prefixed externals are processed as npm packages, and other external prefixes (cargo:, maven:, etc.) are now properly skipped. Fixes #32819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getDependentPackagesForProject function was crashing when processing
projects with non-npm external nodes (e.g., cargo: prefixed nodes from
@monodon/rust plugin). The code only handled npm: prefixed externals and
treated everything else as workspace libraries, causing undefined access
errors when cargo externals were encountered.
This fix adds a check to skip external nodes that aren't npm-prefixed by
detecting the presence of a colon in the dependency target. Only npm:
prefixed externals are processed as npm packages, and other external
prefixes (cargo:, maven:, etc.) are now properly skipped.
Fixes #32819