fix(gradle): support Windows file paths#35184
Merged
Merged
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 2f3204a
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
May 12, 2026
Contributor
FrozenPandaz
left a comment
There was a problem hiding this comment.
Thank you for your contribution! LGTM 🎉
FrozenPandaz
added a commit
that referenced
this pull request
May 12, 2026
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Issues with matching on Windows paths because there are hardcoded forward slashes `/` ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Works on Windows or otherwise ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #34987 Want to note that while the Unit tests are all passing, I don't have a way to test this on a unix machine myself. Also, I'm not super familiar with gradle plugins, how can I "export" my changes here to try in my own project that uses the plugin? Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Issues with matching on Windows paths because there are hardcoded forward slashes
/Expected Behavior
Works on Windows or otherwise
Related Issue(s)
Fixes #34987
Want to note that while the Unit tests are all passing, I don't have a way to test this on a unix machine myself. Also, I'm not super familiar with gradle plugins, how can I "export" my changes here to try in my own project that uses the plugin?