fix(nextjs): multi-version support compliance (NXC-4395)#35870
Merged
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 0575995
☁️ Nx Cloud last updated this comment at |
25106e3 to
ca93ea9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
01b9d60 to
4c4698b
Compare
4c4698b to
14600f8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
50ea8d3 to
00302f5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
## Current Behavior - @nx/next has no below-floor guard; generators silently fall back to latest install constants on unsupported Next versions. - Base 20.7.1-beta.0 migration bumps eslint-config-next ungated, hitting v14 users. ## Expected Behavior - assertSupportedNextVersion (floor Next 14) throws on sub-floor; asserted as first statement in every generator. - Base 20.7.1-beta.0 migration gated to ^15.0.0 so v14 users keep the v14 eslint-config lane. - Inferred plugin TODO replaced with factual comment; v14/v15/v16 emit identical inferred target. - Generator init/style/swc installs default keepExistingVersions true (preserves user-pinned deps). - Fresh-install pins raised to lowest CVE-free patch per major (next 14.2.35 / 15.5.18 / 16.1.6). ## Related Issue(s) Fixes NXC-4395
2c22b74 to
0575995
Compare
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
leosvelperez
approved these changes
Jun 5, 2026
vrxj81
pushed a commit
to vrxj81/nx
that referenced
this pull request
Jun 7, 2026
## Current Behavior `@nx/next` has no below-floor guard; generators silently fall back to latest install constants on unsupported Next versions. The base `20.7.1-beta.0` migration bumps `eslint-config-next` ungated, hitting v14 users. ## Expected Behavior `assertSupportedNextVersion` (floor Next 14) throws on sub-floor and is the first statement in every generator. The base `20.7.1-beta.0` migration is gated to `>=15` so v14 users keep the v14 eslint-config lane. Support window kept at v14+v15+v16. ## Related Issue(s) Fixes NXC-4395 <!-- polygraph-session-start --> --- [View session information ↗](https://snapshot.app.trypolygraph.com/orgs/69cdc268b6aa527e4129c2b4/sessions/multi-4395-ae050ce9) <!-- polygraph-session-end --> --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/nexthas no below-floor guard; generators silently fall back to latest install constants on unsupported Next versions. The base20.7.1-beta.0migration bumpseslint-config-nextungated, hitting v14 users.Expected Behavior
assertSupportedNextVersion(floor Next 14) throws on sub-floor and is the first statement in every generator. The base20.7.1-beta.0migration is gated to>=15so v14 users keep the v14 eslint-config lane. Support window kept at v14+v15+v16.Related Issue(s)
Fixes NXC-4395
View session information ↗