fix(core): skip Nx Console and AI agents checks in CI and speed up e2e browser and port helpers - #37119
Draft
FrozenPandaz wants to merge 4 commits into
Draft
fix(core): skip Nx Console and AI agents checks in CI and speed up e2e browser and port helpers#37119FrozenPandaz wants to merge 4 commits into
FrozenPandaz wants to merge 4 commits into
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 930d023
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
fix/skip-nx-console-check-without-tty
branch
from
September 19, 2026 15:05
482caf3 to
5845897
Compare
FrozenPandaz
changed the base branch from
master
to
e2e-shared-base-workspace
September 19, 2026 15:07
FrozenPandaz
added this pull request to stack #37120
September 19, 2026 15:07
FrozenPandaz
force-pushed
the
fix/skip-nx-console-check-without-tty
branch
from
September 19, 2026 15:54
5845897 to
f0f10d0
Compare
FrozenPandaz
force-pushed
the
fix/skip-nx-console-check-without-tty
branch
3 times, most recently
from
September 19, 2026 17:46
a6a510d to
c67e524
Compare
FrozenPandaz
force-pushed
the
fix/skip-nx-console-check-without-tty
branch
from
September 19, 2026 21:24
c67e524 to
8cdd88f
Compare
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
FrozenPandaz
force-pushed
the
fix/skip-nx-console-check-without-tty
branch
2 times, most recently
from
September 20, 2026 04:56
1adeed5 to
300a746
Compare
…hown Every new daemon primed the Nx Console and AI agents status caches, and both install nx@latest into a temp dir. The CLI also asked for the Nx Console status on every command, even without a TTY. In CI neither result is ever shown, but the daemon restarts on every lockfile change, so each restart paid for another nx@latest install running next to the command. - CLI: only ask for the Nx Console status with a TTY outside CI - daemon: skip priming both caches in CI - task runner: skip the "AI agent configuration is outdated" hint in CI A no-install generate on a warm daemon with CI=true drops from ~0.87s to ~0.58s locally.
…unPlaywrightTests runE2ETests() without an argument prepared both Cypress and Playwright, and 60 of its calls used that form although none needs both browsers. The module federation v2 suites needed neither, yet paid ~30s for the first `cypress verify` on a fresh machine. - Replace it with one helper per browser that prepares only that browser and logs how long it took. - Move every call to the helper for the browser its guarded code runs. - Drop the guard in the module federation v2 suites so `serve` always runs; CI already sets NX_E2E_RUN_E2E.
killPort slept 5s after killing a port before checking it. Poll every 100ms instead, still giving up after 5s. A busy port now closes in ~0.2s locally.
FrozenPandaz
force-pushed
the
fix/skip-nx-console-check-without-tty
branch
from
September 20, 2026 05:00
300a746 to
930d023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has 4 commits, each reviewable on its own:
fix(core): skip the Nx Console and AI agents checks when their result can't be shownchore(repo): splitrunE2ETestsintoshouldRunCypressTestsandshouldRunPlaywrightTestschore(repo): stop waiting a fixed 5s for e2e ports to closechore(repo): log how longkillPorttakes to close a portCurrent Behavior
Nx Console / AI agents checks
Every new daemon primes the Nx Console and AI agents status caches in the background. Both install
nx@latestinto a temp dir (~2s of package-manager work).LOCK_FILES_CHANGED), so any flow that installs packages (e.g. generators that add dependencies) pays for anothernx@latestinstall running next to the next command.e2e helpers
runE2ETests()without an argument prepares both Cypress and Playwright. 60 calls used that form, but none needs both browsers. The module federation v2 suites (vite/rsbuild/rspack) onlyserveand need neither, yet paid ~30s for the firstcypress verifyon a fresh machine.killPortalways sleeps 5s after killing a port before checking it.Expected Behavior
Nx Console / AI agents checks
CIfrom the client that spawned it).CI) is unchanged.e2e helpers
runE2ETestsis replaced byshouldRunCypressTests()andshouldRunPlaywrightTests(). Each prepares only its own browser and logsCypress ready (Ns)/Playwright ready (Ns).serve; CI already setsNX_E2E_RUN_E2E.killPortpolls every 100ms (still gives up after 5s) and logs how long closing took.Measured locally:
nx@latestpulls per daemon start withCI=truenx gon a warm daemon withCI=truekillPorton a busy portRelated Issue(s)
N/A
View Polygraph session ↗