AO3-7213 - Adjust styling to ensure 'Suggest a Language' button is clickable on narrow screens #5520
Conversation
…ickable on narrow screens
sarken
left a comment
There was a problem hiding this comment.
Hi, Juliette Curran!
Thank you so much for the pull request -- I've left a couple of minor comments, but the fix itself looks good. If you can action those comments when you have time, this will be ready to merge.
In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."
Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.
Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.
| margin: 0.643em 0; | ||
| border: none; | ||
| box-shadow: none; | ||
| box-shadow: none; |
There was a problem hiding this comment.
Could you restore the original indenting on this, please? It's our house style to indent CSS3 values by 4 spaces.
There was a problem hiding this comment.
I missed that somehow - I wondered about the reasoning for it and my urge to tidy up got the best of me. Thanks for explaining.
Also RE: Jira, I have made an account: :)
curranjuliette@gmail.com
Juliette Curran
Lastly, initially I thought about picking up AO3-5644 but I think the work may have already been completed. The code suggestions in the ticket are already in place - but I could be looking in the wrong spot.
| box-shadow: none; | ||
| } | ||
|
|
||
| dl.language { |
There was a problem hiding this comment.
This should do the trick! However, could you put this directly above the dl.stats style block a bit lower in the file? It would fit better there instead of in the general, all-purpose dl.index styles.
There was a problem hiding this comment.
Thanks again. It felt iffy putting it where I did - your suggestion makes sense.
…
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7213
Purpose
This PR fixes the issue on narrow screens where the 'Suggest a Language' button moves into the list of languages below and becomes unclickable.
Testing Instructions
Provided on ticket but pasted below:
Access the Work Languages page (Site Map > Languages or https://test.archiveofourown.org/languages)
Resize the browser window so that the “Suggest a Language” button is below the “Work Languages” header (or use a smaller mobile device)
Click the “Suggest a Language” button
Button should redirect you to the Support and Feedback form
Credit
She/Her, Juliette Curran