Skip to content

Conversation

@tenphi
Copy link
Collaborator

@tenphi tenphi commented May 13, 2021

  • code quality improvements
  • use mediaQuery recommended listeners

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2021

This pull request fixes 3 alerts when merging ac8f5fb into a843ae7 - view on LGTM.com

fixed alerts:

  • 3 for Useless regular-expression character escape

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2021

This pull request introduces 2 alerts and fixes 34 when merging 5cfdd0a into a843ae7 - view on LGTM.com

new alerts:

  • 2 for Replacement of a substring with itself

fixed alerts:

  • 13 for Unused variable, import, function or class
  • 6 for Useless conditional
  • 3 for Useless assignment to local variable
  • 3 for Superfluous trailing arguments
  • 3 for Useless regular-expression character escape
  • 2 for Incomplete string escaping or encoding
  • 1 for Identical operands
  • 1 for Comparison between inconvertible types
  • 1 for Useless comparison test
  • 1 for Unneeded defensive code

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2021

This pull request introduces 2 alerts and fixes 34 when merging e9fe894 into f13a554 - view on LGTM.com

new alerts:

  • 2 for Replacement of a substring with itself

fixed alerts:

  • 13 for Unused variable, import, function or class
  • 6 for Useless conditional
  • 3 for Useless assignment to local variable
  • 3 for Superfluous trailing arguments
  • 3 for Useless regular-expression character escape
  • 2 for Incomplete string escaping or encoding
  • 1 for Identical operands
  • 1 for Comparison between inconvertible types
  • 1 for Useless comparison test
  • 1 for Unneeded defensive code

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2021

This pull request introduces 2 alerts and fixes 34 when merging 032964d into f13a554 - view on LGTM.com

new alerts:

  • 2 for Replacement of a substring with itself

fixed alerts:

  • 13 for Unused variable, import, function or class
  • 6 for Useless conditional
  • 3 for Useless assignment to local variable
  • 3 for Superfluous trailing arguments
  • 3 for Useless regular-expression character escape
  • 2 for Incomplete string escaping or encoding
  • 1 for Identical operands
  • 1 for Comparison between inconvertible types
  • 1 for Useless comparison test
  • 1 for Unneeded defensive code

@tenphi tenphi merged commit a986b7e into master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants