Skip to content

Add support for sqlite in sql executor#598

Merged
fsamin merged 1 commit into
ovh:masterfrom
maciekzieba:feat/sqlite_support
Nov 2, 2022
Merged

Add support for sqlite in sql executor#598
fsamin merged 1 commit into
ovh:masterfrom
maciekzieba:feat/sqlite_support

Conversation

@maciekzieba
Copy link
Copy Markdown

@maciekzieba maciekzieba commented Oct 24, 2022

Added sqlite driver support for sql executor.

Signed-off-by: mzieba <maciek.zieba@90poe.io>
@maciekzieba
Copy link
Copy Markdown
Author

@yesnault can you please review it?

@fabriziomoscon
Copy link
Copy Markdown
Contributor

@fsamin @yesnault we had successfully used the fork locally to test. It would be great if you could advise on how to progress with the merge process.
Thank you

@yesnault
Copy link
Copy Markdown
Member

LGTM, thank you @maciekzieba

@fabriziomoscon
Copy link
Copy Markdown
Contributor

@yesnault we can't merge this as we don't have write access to the repo.
Please advise on whether you are waiting for anything else from us.

Copy link
Copy Markdown
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you contribution

@fsamin fsamin merged commit 7f75ae8 into ovh:master Nov 2, 2022
@fabriziomoscon
Copy link
Copy Markdown
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants