Skip to content

feat(executor/redis): Redis auth (ACL) support#784

Merged
yesnault merged 1 commit into
ovh:masterfrom
bastienwirtz:feat/redis-lib-update
Jun 27, 2024
Merged

feat(executor/redis): Redis auth (ACL) support#784
yesnault merged 1 commit into
ovh:masterfrom
bastienwirtz:feat/redis-lib-update

Conversation

@bastienwirtz
Copy link
Copy Markdown
Contributor

@bastienwirtz bastienwirtz commented Apr 5, 2024

Hello,

Bump the redis client to the latest version to support ACL (introduced here)
Btw, the garyburd/redigo/redis has moved to gomodule/redigo/redis. The old repo is unmaintained.

Behavior

Test

- name: Test commands
  steps:
    - type: redis
      dialURL: "redis://{{.user}}:{{.password}}@localhost:6379/0"
      commands:
        - SET foo bar
        - GET foo
        - KEYS *
      assertions:
        - result.commands.commands0.response ShouldEqual OK
        - result.commands.commands1.response ShouldEqual bar
        - result.commands.commands2.response.response0 ShouldEqual foo

Current result

 	• Test-commands
 		• redis FAIL
 		  Testcase "Test commands", step #0-0: WRONGPASS invalid username-password pair or user is disabled.
final status: FAIL

New result

 	• Test-commands
 		• redis PASS
final status: PASS

@bastienwirtz bastienwirtz force-pushed the feat/redis-lib-update branch from f987797 to 94a0c93 Compare April 5, 2024 09:59
@bastienwirtz
chore(executor/redis): update redigo for ACL support
7f953af 
Signed-off-by: Bastien Wirtz <bastien.wirtz@gmail.com>
@bastienwirtz bastienwirtz force-pushed the feat/redis-lib-update branch from 94a0c93 to 7f953af Compare June 24, 2024 09:07
@bastienwirtz
Copy link
Copy Markdown
Contributor Author

bastienwirtz commented Jun 24, 2024

👋 @yesnault,
It would be great to see this little one merged & released :) Let me know if I can do anything to help.
Thanks 🙏

@yesnault
Copy link
Copy Markdown
Member

yesnault commented Jun 27, 2024

Thank you @bastienwirtz , it's ok

@yesnault yesnault merged commit 4a8ab44 into ovh:master Jun 27, 2024
@chenrui333 chenrui333 mentioned this pull request Jan 6, 2026
Closed
storagebits pushed a commit to storagebits/venom that referenced this pull request Apr 17, 2026
@bastienwirtz
chore(executor/redis): update redigo for ACL support (ovh#784)
fe4ef4d 
Signed-off-by: Bastien Wirtz <bastien.wirtz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesnault yesnault yesnault approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bastienwirtz @yesnault