Skip to content

Adding test in the root package in order to test the run command#733

Merged
yesnault merged 3 commits into
ovh:masterfrom
fokion:feat/adding-tests-toplevel
Nov 29, 2023
Merged

Adding test in the root package in order to test the run command#733
yesnault merged 3 commits into
ovh:masterfrom
fokion:feat/adding-tests-toplevel

Conversation

@fokion

@fokion fokion commented Oct 21, 2023

Copy link
Copy Markdown
Contributor

Adding test for the run command , running local tests that we currently only run in E2E.

@fokion fokion changed the title adding test in the root package in order to test the run command WIP-adding test in the root package in order to test the run command Oct 21, 2023
@fokion fokion marked this pull request as draft October 21, 2023 21:30
@fokion fokion changed the title WIP-adding test in the root package in order to test the run command Adding test in the root package in order to test the run command Oct 21, 2023
@fokion fokion force-pushed the feat/adding-tests-toplevel branch from a82c446 to 93d122a Compare October 21, 2023 21:54
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
@fokion fokion force-pushed the feat/adding-tests-toplevel branch from 93d122a to 5eb3b6a Compare October 21, 2023 21:57
@fokion fokion marked this pull request as ready for review October 21, 2023 21:57
@fokion

fokion commented Oct 23, 2023

Copy link
Copy Markdown
Contributor Author

#708

@yesnault yesnault left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the existing IsTest variable instead off adding a new env var VENOM_TEST_MODE and InTestMode attribute.

Comment thread venom.go Outdated
Comment thread venom.go Outdated
Comment thread cmd/venom/run/cmd.go Outdated
Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
@fokion fokion requested a review from yesnault October 23, 2023 18:31
@yesnault yesnault merged commit 75a3d67 into ovh:master Nov 29, 2023
@fokion fokion deleted the feat/adding-tests-toplevel branch November 29, 2023 13:24
storagebits pushed a commit to storagebits/venom that referenced this pull request Apr 17, 2026
ovh#733)

* adding test in the root package in order to test the run command

Signed-off-by: Fokion Sotiropoulos <fokion.s@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants