fix(reports): print applied assertions as YAML in HTML report to handle complex assertions (and, or, etc.) - fixes #754 #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le complex assertions (and, or, etc.) - fixes #754 Signed-off-by: kilianpaquier <git@kilianpaquier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where complex applied assertions in HTML report where shown as
[Object object]. As those are complex (objects), JS handled them as it could.Proposal is to use
YAML.stringifyfor assertions with a little tweak (d-flex gap-2and apre) to show assertions in the right format side by side with status badge.See fix screenshot: