Skip to content

fix(engine): check md5 on artifact download + fix error printing#5846

Merged
sguiheux merged 6 commits into
masterfrom
cdnDownloadMd5
Jun 21, 2021
Merged

fix(engine): check md5 on artifact download + fix error printing#5846
sguiheux merged 6 commits into
masterfrom
cdnDownloadMd5

Conversation

@sguiheux

@sguiheux sguiheux commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator
  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds

ovh-cds commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#16143.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds

ovh-cds commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#16145.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

yesnault
yesnault previously approved these changes Jun 16, 2021
View reviewed changes
richardlt
richardlt reviewed Jun 16, 2021
View reviewed changes
Comment thread engine/worker/internal/handler_download.go
@ovh-cds

ovh-cds commented Jun 16, 2021

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#16153.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud

sonarqubecloud Bot commented Jun 18, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit e825a5c into master Jun 21, 2021
@sguiheux sguiheux deleted the cdnDownloadMd5 branch September 6, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sguiheux @ovh-cds @yesnault @fsamin @richardlt