Skip to content

feat(api): do not consider service as admin or maintainer#6121

Merged
yesnault merged 13 commits into
masterfrom
feat_service_admin
Apr 5, 2022
Merged

feat(api): do not consider service as admin or maintainer#6121
yesnault merged 13 commits into
masterfrom
feat_service_admin

Conversation

@fsamin

@fsamin fsamin commented Mar 29, 2022

Copy link
Copy Markdown
Member

Signed-off-by: francois samin francois.samin@corp.ovh.com

@ovh ovh deleted a comment from ovh-cds Mar 29, 2022
@ovh ovh deleted a comment from ovh-cds Mar 29, 2022
richardlt
richardlt requested changes Mar 31, 2022
View reviewed changes
Comment thread engine/api/router_middleware_auth_permission.go Outdated
fsamin added 3 commits April 1, 2022 09:48
@fsamin
feat(api): do not consider service as admin or maintainer
7166686 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
wip
510c36c 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
wip
de7d55b 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin fsamin force-pushed the feat_service_admin branch from 10d1c9a to de7d55b Compare April 1, 2022 13:40
@fsamin
wip
5794fee 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 1, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17245.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@fsamin
wip
ed17249 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17249.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✘

@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17249.1 ■

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ■

1 similar comment
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17249.1 ■

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ■

@fsamin
wip
bf812b0 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17262.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

fsamin added 3 commits April 4, 2022 15:59
@fsamin
wip
39c2474 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
wip
9bb6454 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin
wip
ef4a780 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17272.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@fsamin
wip
4610e52 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17273.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@fsamin
wip
fbb7669 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17274.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@fsamin
wip
2a93daf 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17275.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@fsamin
wip
9b5c200 
Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17276.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds

ovh-cds commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

CDS Report build-all-cds#17277.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud

sonarqubecloud Bot commented Apr 5, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yesnault yesnault merged commit 3a70613 into master Apr 5, 2022
@fsamin fsamin deleted the feat_service_admin branch May 9, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesnault yesnault yesnault approved these changes

@sguiheux sguiheux sguiheux approved these changes

@richardlt richardlt richardlt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fsamin @ovh-cds @yesnault @sguiheux @richardlt