feat(api,hooks): add v2 hook signature and github repository analysis#6255
Merged
Conversation
yesnault
reviewed
Aug 25, 2022
Co-authored-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
yesnault
approved these changes
Aug 25, 2022
fsamin
requested changes
Aug 25, 2022
| } | ||
|
|
||
| // Create a new HMAC by defining the hash type and the key (as byte array) | ||
| h := hmac.New(sha256.New, []byte(hook.HookSignKey)) |
Member
There was a problem hiding this comment.
question: is it time consuming ?
Collaborator
Author
There was a problem hiding this comment.
the middleware: 35ms with a gitea event on a local environment
richardlt
reviewed
Aug 25, 2022
Collaborator
|
CDS Report build-all-cds#17801.0 ✘
|
fsamin
requested changes
Aug 25, 2022
fsamin
approved these changes
Aug 25, 2022
|
SonarCloud Quality Gate failed. |
richardlt
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ovh/cds