fix(api, worker): auto build info#6264
Merged
Merged
Conversation
Collaborator
|
CDS Report build-all-cds#17834.0 ✘
|
sguiheux
requested changes
Sep 1, 2022
| return err | ||
| } | ||
|
|
||
| var releaseRequest sdk.WorkflowRunResultPromotionRequest |
Collaborator
There was a problem hiding this comment.
releaseRequest -> promotionRequest
| for _, id := range releaseRequest.IDs { | ||
| if id == r.ID { | ||
| log.Debug(ctx, "adding promotion data: %+v", releaseRequest) | ||
| r.DataSync.Promotions = append(r.DataSync.Promotions, releaseRequest.WorkflowRunResultPromotion) |
Collaborator
There was a problem hiding this comment.
Maybe test if promotion maturity is already in the slice
| for _, id := range releaseRequest.IDs { | ||
| if id == r.ID { | ||
| log.Debug(ctx, "adding release data: %+v", releaseRequest) | ||
| r.DataSync.Releases = append(r.DataSync.Releases, releaseRequest.WorkflowRunResultPromotion) |
| return sdk.Result{Status: sdk.StatusFail}, err | ||
| } | ||
|
|
||
| log.Info(ctx, "RunRelease> preparing run result %+v for release", promotedRunResultIDs) |
Collaborator
There was a problem hiding this comment.
Suggested change
| log.Info(ctx, "RunRelease> preparing run result %+v for release", promotedRunResultIDs) | |
| log.Info(ctx, "RunPromote> preparing run result %+v for promotion", promotedRunResultIDs) |
yesnault
approved these changes
Sep 1, 2022
sguiheux
approved these changes
Sep 1, 2022
richardlt
approved these changes
Sep 1, 2022
| version: r.Version, | ||
| projectKey: r.ProjectKey, | ||
| } | ||
| log.Info(ctx, "compute build infos for %+v", execContext) |
Collaborator
|
CDS Report build-all-cds#17837.0 ✘
|
Collaborator
|
CDS Report build-all-cds#17837.1 ✘
|
Collaborator
|
CDS Report build-all-cds#17837.2 ✘
|
Collaborator
|
CDS Report build-all-cds#17837.3 ✘
|
richardlt
approved these changes
Sep 2, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.