feat(tui): add @-triggered file autocomplete suggestions#84
Conversation
MyEcoria
commented
Oct 2, 2025
|
Nice one! I notice a few quirks: if I select a file and press enter the @ stays alone (I would expect to at least see the file name). I would not expect enter to actually send the prompt but to behave just like tab (just adding file path into the input). feedback-1.mp4Then if I go to a directory with a lot of files (like my home) and try to start inputing some files, it hangs and I can't use my terminal anymore, not even Ctrl^C I have to kill my window: feedback-2.mp4 |
17904fc to
bf9d76a
Compare
|
It's good now, we can validate with "Enter" instead of "Tab". I used jwalk to simplify the code, and it's much more performant (there might still be some slowdowns, but it no longer blocks) 🙂 |
|
yes it is much faster indeed! feedback-3-light.mp4Also I think it would probably make sense to not search through .* folder and maybe even blacklist some folder that would slow the searcher down like feedback-4-light.mp4 |
|
Yes, I thought about ignoring files starting with .* but that would also ignore useful ones like .gitignore, .github... I think by default I’ll ignore them, unless the search explicitly includes a '.' |
|
what about ignoring build / libraries files ? do you want to do something or should I merge as is ? |
|
I'm going to make some more changes. I think I'll ignore the files/folder in .gitignore |
|
that's a pretty good idea! |
…the suggestion limit to 20, add a scrolling window with a count title.
|
whenever you are ready, I'll merge your branch but then I'll create a new one to clean input.rs that start to be a little bit messy :) but that will be another PR. |
|
Yes, it's true that it's becoming a bit of a mess ;) |
|
nice PR @MyEcoria ! |